Re: [RFE] Please add name and email to git credentials

2018-11-02 Thread Jeff King
On Fri, Nov 02, 2018 at 06:32:36PM +0100, Nicolas Mailhot wrote: > > I did create the way git credential matches repo urls. And I do not > > think your proposal is a good idea. The credential system is about > > interacting with a remote URL, and creating a commit object is a local > > operation.

Re: [RFE] Please add name and email to git credentials

2018-11-02 Thread Nicolas Mailhot
Le vendredi 02 novembre 2018 à 12:51 -0400, Jeff King a écrit : Hi, Thank you for reading the RFE. > I did create the way git credential matches repo urls. And I do not > think your proposal is a good idea. The credential system is about > interacting with a remote URL, and creating a commit

Re: [RFE] Please add name and email to git credentials

2018-11-02 Thread Jeff King
On Fri, Nov 02, 2018 at 09:57:30AM +0100, Nicolas Mailhot wrote: > Or are you arguing that having two separate mecanisms in git, to match > config directives to repo urls, is some kind of improvement? There are already are multiple mechanisms (e.g., http.* config). So that ship has sailed. ;) >

Re: [RFE] Please add name and email to git credentials

2018-11-02 Thread Nicolas Mailhot
Le vendredi 02 novembre 2018 à 09:27 +0100, Christian Couder a écrit : > On Thu, Nov 1, 2018 at 3:42 PM Nicolas Mailhot > wrote: > > Le jeudi 01 novembre 2018 à 15:13 +0100, Christian Couder a écrit : > > > How can Git know when you commit where you will want to push the > > > commit afterwards?

Re: [RFE] Please add name and email to git credentials

2018-11-02 Thread Christian Couder
On Thu, Nov 1, 2018 at 3:42 PM Nicolas Mailhot wrote: > > Le jeudi 01 novembre 2018 à 15:13 +0100, Christian Couder a écrit : > > > > How can Git know when you commit where you will want to push the > > commit afterwards? > > You have an url in the repo config. of course you can change it between

RE: [RFE] Please add name and email to git credentials

2018-11-01 Thread Randall S. Becker
On November 1, 2018 10:13 AM, Christian Couder wrote: > Sent: > To: nicolas.mail...@laposte.net > Cc: git > Subject: Re: [RFE] Please add name and email to git credentials > > On Thu, Nov 1, 2018 at 2:31 PM Nicolas Mailhot > wrote: > > > > Le jeudi 01 novembre

Re: [RFE] Please add name and email to git credentials

2018-11-01 Thread Nicolas Mailhot
Le jeudi 01 novembre 2018 à 15:13 +0100, Christian Couder a écrit : > > How can Git know when you commit where you will want to push the > commit afterwards? You have an url in the repo config. of course you can change it between the commit and the push, but that's not the general case.

Re: [RFE] Please add name and email to git credentials

2018-11-01 Thread Christian Couder
On Thu, Nov 1, 2018 at 2:31 PM Nicolas Mailhot wrote: > > Le jeudi 01 novembre 2018 à 12:22 +0100, Ævar Arnfjörð Bjarmason a > écrit : > > > > Where would we get an E-Mail to lookup to pass to the helper? Are you > > just asking that the helper git the result of $(git config user.name > > && > >

Re: [RFE] Please add name and email to git credentials

2018-11-01 Thread Ævar Arnfjörð Bjarmason
On Thu, Nov 01 2018, Nicolas Mailhot wrote: > Le jeudi 01 novembre 2018 à 12:22 +0100, Ævar Arnfjörð Bjarmason a > écrit : >> >> Where would we get an E-Mail to lookup to pass to the helper? Are you >> just asking that the helper git the result of $(git config user.name >> && >> git config

Re: [RFE] Please add name and email to git credentials

2018-11-01 Thread Nicolas Mailhot
Le jeudi 01 novembre 2018 à 12:22 +0100, Ævar Arnfjörð Bjarmason a écrit : > > Where would we get an E-Mail to lookup to pass to the helper? Are you > just asking that the helper git the result of $(git config user.name > && > git config user.email)? If so why can't it just look this up itself?

Re: [RFE] Please add name and email to git credentials

2018-11-01 Thread Nicolas Mailhot
Le jeudi 01 novembre 2018 à 10:59 +0100, Nicolas Mailhot a écrit : > Hi, > > A dev persona is not just a username, please add email (and probably > also name) support to git credentials so the correct set for a repo > url > is automatically picked up by git So, just in case it was not clear

Re: [RFE] Please add name and email to git credentials

2018-11-01 Thread Ævar Arnfjörð Bjarmason
On Thu, Nov 01 2018, Nicolas Mailhot wrote: > A dev persona is not just a username, please add email (and probably > also name) support to git credentials so the correct set for a repo url > is automatically picked up by git The "git-credential" helper needs to look at a URL like