Am 10/24/2013 22:04, schrieb Junio C Hamano:
Johannes Sixt j.s...@viscovery.net writes:
That said, I don't think that --change-id option that the user must not
forget to use is any better than a hook that the user must not forget to
install.
That is why I said this in my first response to
Am 10/24/2013 7:25, schrieb Duy Nguyen:
On Thu, Oct 24, 2013 at 11:11 AM, Nasser Grainawi nas...@codeaurora.org
wrote:
It is not clear to me how you envision to make it work.
I don't have the source code.
Now you do:
That said, I don't think that --change-id option that the user must not
forget to use is any better than a hook that the user must not forget to
install.
Having a --change-id option, to my mind, simplifies use of the patch
workflow as it does not require downloading, copying and setting
On Thursday, October 24, 2013 02:11:05 PM james.mo...@gitblit.com wrote:
That said, I don't think that --change-id option that the user must not
forget to use is any better than a hook that the user must not forget to
install.
I'm a bit paranoid. (e.g. I do all my development in a virtual
On Thu, Oct 24, 2013 at 7:11 PM, james.mo...@gitblit.com wrote:
That said, I don't think that --change-id option that the user must not
forget to use is any better than a hook that the user must not forget to
install.
Having a --change-id option, to my mind, simplifies use of the patch
Johannes Sixt j.s...@viscovery.net writes:
Am 10/24/2013 7:25, schrieb Duy Nguyen:
On Thu, Oct 24, 2013 at 11:11 AM, Nasser Grainawi nas...@codeaurora.org
wrote:
It is not clear to me how you envision to make it work.
I don't have the source code.
Now you do:
On Wed, Oct 23, 2013 at 2:50 AM, Junio C Hamano gits...@pobox.com wrote:
It would be just the matter of updating commit_tree_extended() in
commit.c to:
- detect the need to add a new Change-Id: trailer;
- call hash_sha1_file() on the commit object buffer (assuming that
a commit object
Duy Nguyen pclo...@gmail.com writes:
On Wed, Oct 23, 2013 at 2:50 AM, Junio C Hamano gits...@pobox.com wrote:
It would be just the matter of updating commit_tree_extended() in
commit.c to:
- detect the need to add a new Change-Id: trailer;
- call hash_sha1_file() on the commit object
On Wed, Oct 23, 2013 at 11:00 PM, Junio C Hamano gits...@pobox.com wrote:
Duy Nguyen pclo...@gmail.com writes:
On Wed, Oct 23, 2013 at 2:50 AM, Junio C Hamano gits...@pobox.com wrote:
It would be just the matter of updating commit_tree_extended() in
commit.c to:
- detect the need to add a
On Oct 23, 2013, at 8:07 PM, Duy Nguyen wrote:
On Wed, Oct 23, 2013 at 11:00 PM, Junio C Hamano gits...@pobox.com wrote:
Duy Nguyen pclo...@gmail.com writes:
On Wed, Oct 23, 2013 at 2:50 AM, Junio C Hamano gits...@pobox.com wrote:
It would be just the matter of updating
On Thu, Oct 24, 2013 at 11:11 AM, Nasser Grainawi nas...@codeaurora.org wrote:
It is not clear to me how you envision to make it work.
I don't have the source code.
Now you do:
Martin Fick mf...@codeaurora.org writes:
As a Gerrit maintainer, I would suspect that we would
welcome a way to track changes natively in git.
I would suspect that we would not mind git commit --change-id (and
probably git commit-tree --change-id) option that can be used to
tell the command
-Original Message-
From: Junio C Hamano
Sent: Tuesday, October 22, 2013 3:51 PM
snip/
I would think. You might have a funny chicken-and-egg problem with
the signed commit, though. I didn't think that part through.
Respectfully, I do not think there is a chicken and egg
Pyeron, Jason J CTR (US) jason.j.pyeron@mail.mil writes:
-Original Message-
From: Junio C Hamano
Sent: Tuesday, October 22, 2013 3:51 PM
snip/
I would think. You might have a funny chicken-and-egg problem with
the signed commit, though. I didn't think that part through.
for those of us that are not using gerrit...
what is a change-id (semantically, I got from your mail that it is some sort
of unit id set at commit time) and in what way is it different from the
commit-id ?
Cordialement
Jérémy Rosen
+33 (0)1 42 68 28 04
fight key loggers : write some perl
The change-id is exactly like a commit-id, it is an SHA-1 value, but it
is a constant embedded in the commit message.
Why does Gerrit need this value?
Gerrit is based on the concept of revising/polishing a commit or a
series of commits.
For clarity, consider the case of revising a proposed bug
On Mon, Oct 21, 2013 at 8:41 AM, james.mo...@gitblit.com wrote:
The change-id is exactly like a commit-id, it is an SHA-1 value, but it
is a constant embedded in the commit message.
https://gerrit-review.googlesource.com/Documentation/user-changeid.html
goes into more detail about these.
On Mon, Oct 21, 2013 at 09:35:07AM -0700, Shawn Pearce wrote:
On Mon, Oct 21, 2013 at 8:41 AM, james.mo...@gitblit.com wrote:
The change-id is exactly like a commit-id, it is an SHA-1 value, but it
is a constant embedded in the commit message.
On Mon, Oct 21, 2013, at 02:29 PM, Thomas Koch wrote:
As I understand, a UUID could also be used for the same purbose as the
change-
id. How is the change-id generated by the way? Would it be a good english
name
to call it enduring commit identifier?
Here is the algorithm:
On Monday, October 21, 2013 12:40:58 pm
james.mo...@gitblit.com wrote:
On Mon, Oct 21, 2013, at 02:29 PM, Thomas Koch wrote:
As I understand, a UUID could also be used for the same
purbose as the change-
id. How is the change-id generated by the way? Would it
be a good english name
to
On Mon, Oct 21, 2013 at 9:38 AM, Ondřej Bílka nel...@seznam.cz wrote:
On Mon, Oct 21, 2013 at 09:35:07AM -0700, Shawn Pearce wrote:
On Mon, Oct 21, 2013 at 8:41 AM, james.mo...@gitblit.com wrote:
The change-id is exactly like a commit-id, it is an SHA-1 value, but it
is a constant embedded
On Mon, Oct 21, 2013 at 11:40 AM, james.mo...@gitblit.com wrote:
On Mon, Oct 21, 2013, at 02:29 PM, Thomas Koch wrote:
As I understand, a UUID could also be used for the same purbose as the
change-
id. How is the change-id generated by the way? Would it be a good english
name
to call it
22 matches
Mail list logo
