Re: Re* [PATCH] commit-tree: do not pay attention to commit.gpgsign

On Tue, May 03, 2016 at 11:01:11AM -0700, Junio C Hamano wrote: > Ignoring commit.gpgsign option _obviously_ breaks the backward > compatibility, but it is easy to follow the standard pattern in > scripts to honor whatever configuration variable they choose to > follow. E.g. > > case

Re* [PATCH] commit-tree: do not pay attention to commit.gpgsign

Jeff King writes: > So I think the motivation and premise are good, but... > >> -static int commit_tree_config(const char *var, const char *value, void *cb) >> -{ >> -int status = git_gpg_config(var, value, NULL); >> -if (status) >> -return status; >> -if

Re: [PATCH] commit-tree: do not pay attention to commit.gpgsign

On Mon, May 2, 2016 at 5:59 PM, Junio C Hamano wrote: > ba3c69a9 (commit: teach --gpg-sign option, 2011-10-05) introduced a > "signed commit" by teaching --[no-gpg-sign option and commit.gpgsign s/\[no/[no]/ (ditto in the "simpler" patch) > configuration variable to various

Re: [PATCH] commit-tree: do not pay attention to commit.gpgsign

On Mon, May 02, 2016 at 02:58:45PM -0700, Junio C Hamano wrote: > ba3c69a9 (commit: teach --gpg-sign option, 2011-10-05) introduced a > "signed commit" by teaching --[no-gpg-sign option and commit.gpgsign > configuration variable to various commands that create commits. > > Teaching these to