Re: Regression: git no longer works with musl libc's regex impl

2016-10-07 Thread Jakub Narębski
W dniu 07.10.2016 o 00:42, Ramsay Jones pisze: > On 06/10/16 20:18, Ævar Arnfjörð Bjarmason wrote: [...] >> But just to clarify, does anyone have any objection to making our >> configure.ac compile a C program to check for this sort of thing? >> Because that seems like the easiest solution to

Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Ramsay Jones
On 06/10/16 20:18, Ævar Arnfjörð Bjarmason wrote: > On Tue, Oct 4, 2016 at 6:08 PM, Johannes Schindelin > wrote: >> As to making NO_REGEX conditional on REG_STARTEND: you are talking about >> apples and oranges here. NO_REGEX is a Makefile flag, while REG_STARTEND >>

Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Jeff King
On Thu, Oct 06, 2016 at 03:25:00PM -0400, Rich Felker wrote: > > No, I think that is the exact purpose of configure.ac and autoconf. > > > > It would be neat if we could auto-fallback during the build. Rich > > suggested always compiling compat/regex.c, and just having it be a noop > > at the

Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Rich Felker
On Thu, Oct 06, 2016 at 03:23:40PM -0400, Jeff King wrote: > On Thu, Oct 06, 2016 at 09:18:29PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > On Tue, Oct 4, 2016 at 6:08 PM, Johannes Schindelin > > wrote: > > > As to making NO_REGEX conditional on REG_STARTEND: you are

Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Jeff King
On Thu, Oct 06, 2016 at 09:18:29PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Tue, Oct 4, 2016 at 6:08 PM, Johannes Schindelin > wrote: > > As to making NO_REGEX conditional on REG_STARTEND: you are talking about > > apples and oranges here. NO_REGEX is a Makefile

Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Ævar Arnfjörð Bjarmason
On Tue, Oct 4, 2016 at 6:08 PM, Johannes Schindelin wrote: > As to making NO_REGEX conditional on REG_STARTEND: you are talking about > apples and oranges here. NO_REGEX is a Makefile flag, while REG_STARTEND > is a C preprocessor macro. > > Unless you can convince the

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Johannes Schindelin
Hi James, On Wed, 5 Oct 2016, James B wrote: > On Wed, 5 Oct 2016 12:41:50 +0200 (CEST) > Johannes Schindelin wrote: > > It's a very sad day for a tool that was developed originally to maintain > Linux kernel, by the Linux kernel author, now is restricted to avoid >

RE: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread writeonce
Hi Johannes, > > > Original Message > Subject: RE: [musl] Re: Regression: git no longer works with musl libc's > regex impl > From: Johannes Schindelin <johannes.schinde...@gmx.de> > Date: Wed, October 05, 2016 3:49 am > To: writeo...@midipix.org

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Rich Felker
On Wed, Oct 05, 2016 at 12:11:58PM -0400, Jeff King wrote: > On Wed, Oct 05, 2016 at 10:59:34PM +1100, James B wrote: > > > Number downloads does not make first-tier platform. You know that as > > well as everyone else. > > > > First-tier support is the decision made by the maintainers that the

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Rich Felker
On Wed, Oct 05, 2016 at 03:11:05PM +0200, Jakub Narębski wrote: > W dniu 05.10.2016 o 00:33, Rich Felker pisze: > > On Wed, Oct 05, 2016 at 09:06:25AM +1100, James B wrote: > >> On Tue, 4 Oct 2016 18:08:33 +0200 (CEST) > >> Johannes Schindelin wrote: > >>> > >>> No, it

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Jeff King
On Wed, Oct 05, 2016 at 10:59:34PM +1100, James B wrote: > Number downloads does not make first-tier platform. You know that as > well as everyone else. > > First-tier support is the decision made by the maintainers that the > entire features of the software must be available on those first tier

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Rich Felker
On Wed, Oct 05, 2016 at 01:17:49PM +0200, Johannes Schindelin wrote: > Hi Rich, > > On Tue, 4 Oct 2016, Rich Felker wrote: > > > On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: > > > > > And lastly, the best alternative would be to teach musl about > > > REG_STARTEND, as it

Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Jakub Narębski
W dniu 05.10.2016 o 00:33, Rich Felker pisze: > On Wed, Oct 05, 2016 at 09:06:25AM +1100, James B wrote: >> On Tue, 4 Oct 2016 18:08:33 +0200 (CEST) >> Johannes Schindelin wrote: >>> >>> No, it is not. You quote POSIX, but the matter of the fact is that we use >>> a

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Szabolcs Nagy
* Johannes Schindelin [2016-10-05 13:17:49 +0200]: > I had a brief look at the source code (you use backtracking... hopefully > nobody uses musl to parse regular expressions from untrusted, or > inexperienced, sources [*1*]), and it seems that the regex code might

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread James B
On Wed, 5 Oct 2016 12:41:50 +0200 (CEST) Johannes Schindelin wrote: > > > > Wow, I don't know that Windows is a git's first-tier platform now, > > It is. Git for Windows is maintained by me, and I make as certain as I can > that it works fine. > And yes, we have

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Johannes Schindelin
Hi Rich, On Tue, 4 Oct 2016, Rich Felker wrote: > On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: > > > And lastly, the best alternative would be to teach musl about > > REG_STARTEND, as it is rather useful a feature. > > Maybe, but it seems fundamentally costly to support

RE: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Johannes Schindelin
Hi writeonce, On Tue, 4 Oct 2016, writeo...@midipix.org wrote: > < On Tue, 4 Oct 2016, Rich Felker wrote: > < > < > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > < > > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > < > > > < > > > 1. is nonzero mod page size, it

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-05 Thread Johannes Schindelin
Hi James, On Wed, 5 Oct 2016, James B wrote: > On Tue, 4 Oct 2016 18:08:33 +0200 (CEST) > Johannes Schindelin wrote: > > > No, it is not. You quote POSIX, but the matter of the fact is that we > > use a subset of POSIX in order to be able to keep things running on >

RE: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread writeonce
< < < Original Message < Subject: [musl] Re: Regression: git no longer works with musl libc's < regex impl < From: Johannes Schindelin <johannes.schinde...@gmx.de> < Date: Tue, October 04, 2016 9:08 am < To: Rich Felker <dal...@libc.org>

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Junio C Hamano
Rich Felker writes: > This is especially unfriendly when the semantics of the switch come > across, at least to some users, as "your system regex is incomplete" > rather than "git can't use it because git depends on nonstandard > extensions". The latter is exactly what Makefile

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Rich Felker
On Wed, Oct 05, 2016 at 09:06:25AM +1100, James B wrote: > On Tue, 4 Oct 2016 18:08:33 +0200 (CEST) > Johannes Schindelin wrote: > > > > > No, it is not. You quote POSIX, but the matter of the fact is that we use > > a subset of POSIX in order to be able to keep

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread James B
On Tue, 4 Oct 2016 18:08:33 +0200 (CEST) Johannes Schindelin wrote: > > No, it is not. You quote POSIX, but the matter of the fact is that we use > a subset of POSIX in order to be able to keep things running on Windows. > > And quite honestly, there are lots of

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Ray Donnelly
On Tue, Oct 4, 2016 at 6:16 PM, Johannes Schindelin wrote: > Hi Rich, > > On Tue, 4 Oct 2016, Rich Felker wrote: > >> On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: >> > Hi Rich, >> > >> > On Tue, 4 Oct 2016, Rich Felker wrote: >> > >> > > On Tue,

Re: [musl] Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Rich Felker
On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: > Hi Rich, > > On Tue, 4 Oct 2016, Rich Felker wrote: > > > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > > > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > > > > > > > 1. is nonzero mod page

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Johannes Schindelin
Hi Rich, On Tue, 4 Oct 2016, Rich Felker wrote: > On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: > > Hi Rich, > > > > On Tue, 4 Oct 2016, Rich Felker wrote: > > > > > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > > > > On Tue, Oct 04, 2016 at 11:08:48AM

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Rich Felker
On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: > Hi Rich, > > On Tue, 4 Oct 2016, Rich Felker wrote: > > > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > > > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > > > > > > > 1. is nonzero mod page

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Johannes Schindelin
Hi Rich, On Tue, 4 Oct 2016, Rich Felker wrote: > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > > > > > 1. is nonzero mod page size, it just works; the remainder of the last > > >page reads as zero bytes when

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Johannes Schindelin
Hi, On Tue, 4 Oct 2016, Jeff King wrote: > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > > > 1. is nonzero mod page size, it just works; the remainder of the last > >page reads as zero bytes when mmapped. > > Is that a portable assumption? No. Ciao, Dscho

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Rich Felker
On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > > > This commit broke support for using git with musl libc: > > > > https://github.com/git/git/commit/2f8952250a84313b74f96abb7b035874854cf202 > > Yep. The idea is that

Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Jeff King
On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > This commit broke support for using git with musl libc: > > https://github.com/git/git/commit/2f8952250a84313b74f96abb7b035874854cf202 Yep. The idea is that you would compile git with NO_REGEX=1, and it would use the included compat

Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Rich Felker
This commit broke support for using git with musl libc: https://github.com/git/git/commit/2f8952250a84313b74f96abb7b035874854cf202 Rather than depending on non-portable GNU regex extensions, there is a simple portable fix for the issue this code was added to work around: When a text file is