While investigating this StackOverflow question:
http://stackoverflow.com/questions/15516168/how-to-cross-compile-git-for-arm
I found that fetch-pack.c uses ST_MTIME_NSEC outside of the protection
of #ifdef USE_NSEC. This results in a broken build if
!defined(USE_NSEC) !defined(NO_NSEC) and the
On Wed, Mar 20, 2013 at 02:36:32AM -0400, Andrew Rodland wrote:
While investigating this StackOverflow question:
http://stackoverflow.com/questions/15516168/how-to-cross-compile-git-for-arm
I found that fetch-pack.c uses ST_MTIME_NSEC outside of the protection
of #ifdef USE_NSEC. This results
Jeff King p...@peff.net writes:
But maybe there is some subtle reason I'm missing for having the two
options separate.
The closest I found was c06ff4908bf9 (Record ns-timestamps if
possible, but do not use it without USE_NSEC, 2009-03-04).
commit c06ff4908bf9ad8bf2448439a3574321c9399b17
On Wed, Mar 20, 2013 at 10:04:14AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
But maybe there is some subtle reason I'm missing for having the two
options separate.
The closest I found was c06ff4908bf9 (Record ns-timestamps if
possible, but do not use it without
Jeff King p...@peff.net writes:
And the cost is that we have another Makefile knob people need to tweak
that would not otherwise need to be there. Which can be annoying, but is
also not that huge a cost to deal with (we might want to improve the
configure script or something, though).
I
On Wed, Mar 20, 2013 at 1:31 PM, Junio C Hamano gits...@pobox.com wrote:
Jeff King p...@peff.net writes:
And the cost is that we have another Makefile knob people need to tweak
that would not otherwise need to be there. Which can be annoying, but is
also not that huge a cost to deal with (we
On Wed, Mar 20, 2013 at 02:22:27PM -0400, Andrew Rodland wrote:
I think it would be good if NO_NSEC and USE_ST_TIMESPEC were
controlled by configure instead of config.mak, and it doesn't seem
like too tall of an order.
There is no instead of here. The Makefile provides knobs which you can
Jeff King p...@peff.net writes:
So I think your real complaint is configure does not set NO_NSEC
properly, which is something worth fixing.
Yes.
I think our Meh was about do we want to unify USE_NSEC and
NO_NSEC? and nothing else.
--
To unsubscribe from this list: send the line unsubscribe
On Wed, Mar 20, 2013 at 11:52:28AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
So I think your real complaint is configure does not set NO_NSEC
properly, which is something worth fixing.
Yes.
I think our Meh was about do we want to unify USE_NSEC and
NO_NSEC? and
9 matches
Mail list logo
