Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Jeff King
On Wed, Oct 17, 2012 at 11:06:11PM -0700, Junio C Hamano wrote: > >> - eval "$(set_ident AUTHOR <../commit)" || > >> + eval "$(set_ident AUTHOR author <../commit)" || > > > > I cringe a little at losing DRY-ness to avoid processes. > > Well, the header field token "author" and the middle word o

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Junio C Hamano
Jeff King writes: > On Thu, Oct 18, 2012 at 07:31:35AM +0200, Johannes Sixt wrote: > >> Right. But we should really be doing something like this instead to save a >> few subprocesses. >> [...] >> -eval "$(set_ident AUTHOR <../commit)" || >> +eval "$(set_ident AUTHOR author <../commit)" ||

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Jeff King
On Thu, Oct 18, 2012 at 07:31:35AM +0200, Johannes Sixt wrote: > Right. But we should really be doing something like this instead to save a > few subprocesses. > [...] > - eval "$(set_ident AUTHOR <../commit)" || > + eval "$(set_ident AUTHOR author <../commit)" || I cringe a little at los

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Johannes Sixt
Am 10/18/2012 0:09, schrieb Jeff King: > - lid="$(echo "$1" | tr "[A-Z]" "[a-z]")" > - uid="$(echo "$1" | tr "[a-z]" "[A-Z]")" > + lid="$(echo "$1" | tr ABCDEFGHIJKLMNOPQRSTUVWXYZ > abcdefghijklmnopqrstuvwxyz)" > + uid="$(echo "$1" | tr abcdefghijklmnopqrstuvwxyz > ABCDEFGHIJKLMNO

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Jeff King
On Wed, Oct 17, 2012 at 02:36:23PM +0400, Ilya Basin wrote: > The culprit is bad $PATH : > When git-filter-branch runs, for some reason two new entries precede > /usr/bin in it: > /tmp/777/.ilya-sparc/bin > /home/tester/.ilya/opt/SNiFF-3.2.1/bin > /export/home/testora/app/testora/pr

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Jeff King
On Wed, Oct 17, 2012 at 12:58:47PM +0400, Ilya Basin wrote: > JS> Most likely, your sed has problems with a sed script in function > JS> get_author_ident_from_commit. I tested it like this: > > JS> $ sh -c '. $(git --exec-path)/git-sh-setup; > JS> get_author_ident_from_commit HEAD

Re[3]: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Ilya Basin
JS>> Most likely, your sed has problems with a sed script in function JS>> get_author_ident_from_commit. I tested it like this: JS>> $ sh -c '. $(git --exec-path)/git-sh-setup; JS>> get_author_ident_from_commit HEAD' JS>> GIT_AUTHOR_NAME='Johannes Sixt' JS>> GIT_AUTHOR_EMAIL='j...@

Re[2]: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Ilya Basin
JS> Most likely, your sed has problems with a sed script in function JS> get_author_ident_from_commit. I tested it like this: JS> $ sh -c '. $(git --exec-path)/git-sh-setup; JS> get_author_ident_from_commit HEAD' JS> GIT_AUTHOR_NAME='Johannes Sixt' JS> GIT_AUTHOR_EMAIL='j...@kdbg.o

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Johannes Sixt
Am 10/17/2012 8:47, schrieb Ilya Basin: > The filter-branch command, the contents of ~/.gitconfig and the tree > are the same. > The command succeeds on cygwin, but fails on Solaris due to > unset GIT_AUTHOR_NAME and GIT_COMMITTER_NAME : > > $ git filter-branch --tree-filter "env | grep GIT_ ; $CM

Re: What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-17 Thread Jeff King
On Wed, Oct 17, 2012 at 10:47:29AM +0400, Ilya Basin wrote: > The filter-branch command, the contents of ~/.gitconfig and the tree > are the same. > The command succeeds on cygwin, but fails on Solaris due to > unset GIT_AUTHOR_NAME and GIT_COMMITTER_NAME : That shouldn't happen. The likely culpr

What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris?

2012-10-16 Thread Ilya Basin
The filter-branch command, the contents of ~/.gitconfig and the tree are the same. The command succeeds on cygwin, but fails on Solaris due to unset GIT_AUTHOR_NAME and GIT_COMMITTER_NAME : $ git filter-branch --tree-filter "env | grep GIT_ ; $CMD" b416b9bfc5e71531f2f05af4c396bb0ba7560741..HEAD R