Re: check-attr doesn't respect recursive definitions

2013-04-06 Thread Jan Larres
Duy Nguyen wrote: > On Sat, Mar 30, 2013 at 8:45 PM, Jan Larres wrote: >> I would expect the last command to also report 'set'. I've also tried >> other patterns like 'foo/' and 'foo*', but it didn't make any >> difference. > > Try "foo/**". You need 1.8.2 though. That indeed works exactly the w

Re: check-attr doesn't respect recursive definitions

2013-04-04 Thread Duy Nguyen
On Sat, Mar 30, 2013 at 8:45 PM, Jan Larres wrote: > I would expect the last command to also report 'set'. I've also tried > other patterns like 'foo/' and 'foo*', but it didn't make any > difference. Try "foo/**". You need 1.8.2 though. -- Duy -- To unsubscribe from this list: send the line "uns

Re: check-attr doesn't respect recursive definitions

2013-04-03 Thread Jan Larres
Thanks for the clarifications. Just a quick comment about the summary: Jeff King wrote: > Yeah, I had the same thought. So you would have to either: > > 1. Hook the feature into git-archive, which knows about how it > recurses, and can report the correct set of paths. > > or > > 2. Tell

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 10:16:55AM -0700, Junio C Hamano wrote: > > Yes, but as I explained later, the meaning of "apply an attribute to > > dir" in such cases is always equivalent to "apply attribute > > recursively to dir/*". So I do not think we are violating that rule to > > recursively apply

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Junio C Hamano
Jeff King writes: > On Tue, Apr 02, 2013 at 09:43:30AM -0700, Junio C Hamano wrote: > >> > In some systems, yes, but git does not have any notion of "doc/" as an >> > item (after all, we track content in files, not directories), so I do >> > not see what it means to specify a directory except to

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 12:51:28PM -0400, Jeff King wrote: > But let's take a step back. I think Jan is trying to do a very > reasonable thing: come up with the same set of paths that git-archive > would. What's the best way to solve that? Recursive application of > attributes is one way, but is t

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 09:43:30AM -0700, Junio C Hamano wrote: > > In some systems, yes, but git does not have any notion of "doc/" as an > > item (after all, we track content in files, not directories), so I do > > not see what it means to specify a directory except to say "everything > > under

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Junio C Hamano
Jeff King writes: > On Tue, Apr 02, 2013 at 09:11:02AM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > Yes, it is the expected behavior, though I cannot offhand think of >> > anything that would break if we did apply it recursively. >> >> Conceptually that breaks our brain. "All f

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 09:11:02AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Yes, it is the expected behavior, though I cannot offhand think of > > anything that would break if we did apply it recursively. > > Conceptually that breaks our brain. "All files in doc/ directories > ar

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Junio C Hamano
Jeff King writes: > Yes, it is the expected behavior, though I cannot offhand think of > anything that would break if we did apply it recursively. Conceptually that breaks our brain. "All files in doc/ directories are text" and "doc/ directory is text" are two different things, no? -- To unsub

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 10:31:30AM -0400, Jeff King wrote: > On Sat, Mar 30, 2013 at 09:45:51AM +, Jan Larres wrote: > > > I am trying to write a custom archiving script that checks the > > export-ignore attribute to know which files from an ls-files output it > > should skip. Through this I

Re: check-attr doesn't respect recursive definitions

2013-04-02 Thread Jeff King
On Sat, Mar 30, 2013 at 09:45:51AM +, Jan Larres wrote: > I am trying to write a custom archiving script that checks the > export-ignore attribute to know which files from an ls-files output it > should skip. Through this I noticed that for files in directories for > which the export-ignore (o

check-attr doesn't respect recursive definitions

2013-03-30 Thread Jan Larres
Hi, I am trying to write a custom archiving script that checks the export-ignore attribute to know which files from an ls-files output it should skip. Through this I noticed that for files in directories for which the export-ignore (or any other) attribute is set, check-attr still reports 'unspeci