Re: compactionHeuristic=true is not used by interactive staging

2016-06-15 Thread Alex Prengère
I see, it makes sense ;-) Indeed it would seem logical to have all commands showing diffs (diff, add -p, log -p, reset -p, etc..) respect the diff options. Thanks for your quick answer! 2016-06-14 23:45 GMT+02:00 Junio C Hamano : > Jeff King writes: > >> Nobody

Re: compactionHeuristic=true is not used by interactive staging

2016-06-14 Thread Junio C Hamano
Jeff King writes: > Nobody noticed so far because originally the compaction heuristic was on > by default, and so just worked everywhere. But we backed off on that at > the last minute after finding a few cases where the diff looks worse. Yup, and that is why this is called

Re: compactionHeuristic=true is not used by interactive staging

2016-06-14 Thread Jeff King
On Tue, Jun 14, 2016 at 04:22:54PM +0200, Alex Prengère wrote: > Hello, > I just did a fresh clone of git from Github and installed the version > 2.9.0 on Fedora 22. > > I tried the new compactionHeuristic = true, which is awesome. > The only thing that struck me was that this option was not

compactionHeuristic=true is not used by interactive staging

2016-06-14 Thread Alex Prengère
Hello, I just did a fresh clone of git from Github and installed the version 2.9.0 on Fedora 22. I tried the new compactionHeuristic = true, which is awesome. The only thing that struck me was that this option was not used when doing an interactive staging, meaning `git diff` and `git add -p`