Re: git clean performance issues

2015-11-13 Thread Jeff King
On Fri, Nov 13, 2015 at 03:19:07PM +0100, Andreas Krey wrote: > On Sat, 04 Apr 2015 15:55:07 +, Jeff King wrote: > ... > > I think this is the same issue that was discussed here: > > > > http://thread.gmane.org/gmane.comp.version-control.git/265560/focus&5585 > > > > There is some

Re: git clean performance issues

2015-11-13 Thread Andreas Krey
On Sat, 04 Apr 2015 15:55:07 +, Jeff King wrote: ... > I think this is the same issue that was discussed here: > > http://thread.gmane.org/gmane.comp.version-control.git/265560/focus&5585 > > There is some discussion of a possible fix in that thread. I was hoping > that Andreas was going

git clean performance issues

2015-04-04 Thread erik elfström
Hi, I'm having a performance issue with git clean -qxfd (note, not using -ff). The performance issue shows up when trying to clean untracked directories that themselves contain many sub directories. The performance is highly non linear with the number of sub directories. Some test numbers: Dirs

Re: git clean performance issues

2015-04-04 Thread Jeff King
On Sat, Apr 04, 2015 at 10:39:47PM +0200, erik elfström wrote: That looks like the same issue. The use is_git_directory approach sounds good to me, is that the direction you would prefer? I can try to cobble something together although I must warn you I have zero previous experience with this

Re: git clean performance issues

2015-04-04 Thread Jeff King
On Sat, Apr 04, 2015 at 08:32:45PM +0200, erik elfström wrote: In my scenario get_ref_cache will be called 1+ times, each time with a new path. The final few calls will need to search through and compare 1+ entries before realizing that there is no existing entry. This quickly ads up

Re: git clean performance issues

2015-04-04 Thread erik elfström
That looks like the same issue. The use is_git_directory approach sounds good to me, is that the direction you would prefer? I can try to cobble something together although I must warn you I have zero previous experience with this code base so a few iterations will probably be needed. /Erik On