Re: gitweb html validation

2016-11-18 Thread Ralf Thielow
2016-11-15 19:26 GMT+01:00 Ralf Thielow : Finally I've found the time to actually try this out and there are some problems with it. > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 7cf68f07b..33d7c154f 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -5531,8 +5531

Re: gitweb html validation

2016-11-16 Thread Raphaël Gertz
Le 16.11.2016 01:05, Junio C Hamano a écrit : Ralf Thielow writes: Only block level elements are allowed to be inside form tags, according to https://www.w3.org/2010/04/xhtml10-strict.html#elem_form ... I think it's better to just move the -Tag outside of the surrounding div? Something like th

Re: gitweb html validation

2016-11-15 Thread Junio C Hamano
Ralf Thielow writes: > Only block level elements are > allowed to be inside form tags, according to > https://www.w3.org/2010/04/xhtml10-strict.html#elem_form > ... > I think it's better to just move the -Tag outside of the > surrounding div? > Something like this perhaps, I didn't test it myself

Re: gitweb html validation

2016-11-15 Thread Ralf Thielow
Raphaël Gertz wrote: > Hi, > > There a small bug in gitweb html validation, you need the following patch to > pass w3c check with searchbox enabled. > > The problem lies in the input directly embed inside a form without a wrapper > which is not valid. > I agree this is

gitweb html validation

2016-11-15 Thread Raphaël Gertz
Hi, There a small bug in gitweb html validation, you need the following patch to pass w3c check with searchbox enabled. The problem lies in the input directly embed inside a form without a wrapper which is not valid. Best regards The following patch fix the issue for git-2.10.2 : --- /usr