Re: storing cover letter of a patch series?

From: "Duy Nguyen" On Tue, Aug 16, 2016 at 12:26 PM, Jacob Keller wrote: They can just add "squash! cover! " commits for that ;-) Though more likely the advanced workflow would be used... We'll need both (more than one) options. Or even better,

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 11:45 PM, Duy Nguyen wrote: > On Tue, Aug 16, 2016 at 12:26 PM, Jacob Keller wrote: They can just add "squash! cover! " commits for that ;-) Though more likely the advanced workflow would be used... We'll need

Re: storing cover letter of a patch series?

On Tue, Aug 16, 2016 at 12:26 PM, Jacob Keller wrote: >>> They can just add "squash! cover! " commits for that ;-) Though more >>> likely the advanced workflow would be used... We'll need both (more than >>> one) options. >> >> Or even better, "git commit --reword $SHA1"

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 8:45 PM, Duy Nguyen wrote: > On Tue, Aug 16, 2016 at 3:46 AM, Philip Oakley wrote: >> From: "Jacob Keller" >> [nip] I've no problem with more extensive methods for those preparing very big

Re: storing cover letter of a patch series?

On Tue, Aug 16, 2016 at 3:46 AM, Philip Oakley wrote: > From: "Jacob Keller" > [nip] >>> >>> >>> I've no problem with more extensive methods for those preparing very big >>> patch series, or with those needing to merge together a lot of series and

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 1:38 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> Some people have suggested this simple idea, and I like it, but they >> did mention that modifying the cover letter now requires a rebase over >> a potentially large

Re: storing cover letter of a patch series?

From: "Jacob Keller" [nip] I've no problem with more extensive methods for those preparing very big patch series, or with those needing to merge together a lot of series and want to keep the cover letters, but ensuring that a simple flow is possible should still be

Re: storing cover letter of a patch series?

Jacob Keller writes: > Some people have suggested this simple idea, and I like it, but they > did mention that modifying the cover letter now requires a rebase over > a potentially large series of patches, which can get annoying. That can be simply solved by keeping the

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 5:37 AM, Philip Oakley wrote: > [sorry if this is not the right place to 'drop in'..] > I appreciate there has been a lot of discussion, but it mainly appears to be > about an upstream / integration viewpoint. > > I'd hate it if there was a one size

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 08:30:03PM +0700, Duy Nguyen wrote: > On Mon, Aug 15, 2016 at 7:37 PM, Philip Oakley wrote: > > I appreciate there has been a lot of discussion, but it mainly appears to be > > about an upstream / integration viewpoint. > > > > I'd hate it if there

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 7:37 PM, Philip Oakley wrote: > I appreciate there has been a lot of discussion, but it mainly appears to be > about an upstream / integration viewpoint. > > I'd hate it if there was a one size fits all solution that was only focused > on one

Re: storing cover letter of a patch series?

From: "Duy Nguyen" On Mon, Aug 15, 2016 at 1:28 PM, Stefan Beller wrote: On Sun, Aug 14, 2016 at 12:15 AM, Jacob Keller wrote: On Sat, Aug 13, 2016 at 1:49 AM, Duy Nguyen wrote: On Tue, Aug 9, 2016 at 12:27

Re: storing cover letter of a patch series?

On Mon, Aug 15, 2016 at 1:28 PM, Stefan Beller wrote: > On Sun, Aug 14, 2016 at 12:15 AM, Jacob Keller wrote: >> On Sat, Aug 13, 2016 at 1:49 AM, Duy Nguyen wrote: >>> On Tue, Aug 9, 2016 at 12:27 AM, Stefan Beller

Re: storing cover letter of a patch series?

On Sun, Aug 14, 2016 at 11:49 PM, Stefan Beller wrote: > On Sun, Aug 14, 2016 at 11:38 PM, Jacob Keller wrote: >> On Sun, Aug 14, 2016 at 11:28 PM, Stefan Beller wrote: >>> I would imagine this is similar to the pull requests on

Re: storing cover letter of a patch series?

On Sun, Aug 14, 2016 at 11:38 PM, Jacob Keller wrote: > On Sun, Aug 14, 2016 at 11:28 PM, Stefan Beller wrote: >> I would imagine this is similar to the pull requests on the linux >> mailing list, i.e. >> how it is with merges. Back in the time we did

Re: storing cover letter of a patch series?

On Sun, Aug 14, 2016 at 11:28 PM, Stefan Beller wrote: > I would imagine this is similar to the pull requests on the linux > mailing list, i.e. > how it is with merges. Back in the time we did not open the editor for you to > talk about the merge you just did, and then we

Re: storing cover letter of a patch series?

On Sun, Aug 14, 2016 at 12:15 AM, Jacob Keller wrote: > On Sat, Aug 13, 2016 at 1:49 AM, Duy Nguyen wrote: >> On Tue, Aug 9, 2016 at 12:27 AM, Stefan Beller wrote: >>> is what you want. Maybe we want to see a patch that adds the

Re: storing cover letter of a patch series?

On Sat, Aug 13, 2016 at 1:49 AM, Duy Nguyen wrote: > On Tue, Aug 9, 2016 at 12:27 AM, Stefan Beller wrote: >> is what you want. Maybe we want to see a patch that adds the reverse >> functionality as well, i.e. git-am will store the the cover letter as the

Re: storing cover letter of a patch series?

On Tue, Aug 9, 2016 at 12:27 AM, Stefan Beller <sbel...@google.com> wrote: > On Thu, Sep 10, 2015 at 9:28 AM, Jacob Keller <jacob.kel...@gmail.com> wrote: >> Hey, >> >> does anyone know of any tricks for storing a cover letter for a patch >> series inside of

Re: storing cover letter of a patch series?

Junio C Hamano venit, vidit, dixit 08.08.2016 19:42: > Duy Nguyen writes: > >> git-notes was mentioned in this thread back in 2015, but I think it's >> discarded because of the argument that's part of the cover letter was >> not meant to be kept permanently. > > I do not

Re: storing cover letter of a patch series?

Stefan Beller <sbel...@google.com> writes: > On Thu, Sep 10, 2015 at 9:28 AM, Jacob Keller <jacob.kel...@gmail.com> wrote: >> Hey, >> >> does anyone know of any tricks for storing a cover letter for a patch >> series inside of git somehow? I'd guess the on

Re: storing cover letter of a patch series?

Duy Nguyen writes: > git-notes was mentioned in this thread back in 2015, but I think it's > discarded because of the argument that's part of the cover letter was > not meant to be kept permanently. I do not think the reason why we didn't think the notes mechanism was a good

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 9:28 AM, Jacob Keller <jacob.kel...@gmail.com> wrote: > Hey, > > does anyone know of any tricks for storing a cover letter for a patch > series inside of git somehow? I'd guess the only obvious way currently > is to store it at the top of the seri

Re: storing cover letter of a patch series?

On Sun, Aug 7, 2016 at 7:12 AM, Michael S. Tsirkin wrote: > On Fri, Aug 05, 2016 at 08:39:58AM -0700, Junio C Hamano wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Sep 10, 2015 at 11:39:49AM -0700, Junio C Hamano wrote: >> >> The problem with "empty

Re: storing cover letter of a patch series?

On Sun, Aug 07, 2016 at 08:12:23AM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 05, 2016 at 08:39:58AM -0700, Junio C Hamano wrote: > > * When you updated an existing topic, you tell a tool like "rebase > >-i -p" to recreate "lit" branch on top of the mainline. This > >would give you

Re: storing cover letter of a patch series?

On Fri, Aug 05, 2016 at 08:39:58AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Sep 10, 2015 at 11:39:49AM -0700, Junio C Hamano wrote: > >> The problem with "empty commit trick" is that it is a commit whose > >> sole purpose is to describe the

Re: storing cover letter of a patch series?

Junio C Hamano writes: > On Fri, Aug 5, 2016 at 2:20 PM, Martin Fick wrote: >> On Friday, August 05, 2016 08:39:58 AM you wrote: >>> * A new topic, when you merge it to the "lit" branch, you >>> describe the cover as the merge commit message. >>> >>> *

Re: storing cover letter of a patch series?

On Fri, Aug 5, 2016 at 2:20 PM, Martin Fick wrote: > On Friday, August 05, 2016 08:39:58 AM you wrote: >> * A new topic, when you merge it to the "lit" branch, you >> describe the cover as the merge commit message. >> >> * When you updated an existing topic, you tell a

Re: storing cover letter of a patch series?

On Friday, August 05, 2016 08:39:58 AM you wrote: > * A new topic, when you merge it to the "lit" branch, you > describe the cover as the merge commit message. > > * When you updated an existing topic, you tell a tool > like "rebase -i -p" to recreate "lit" branch on top of > the mainline.

Re: storing cover letter of a patch series?

"Michael S. Tsirkin" writes: > On Thu, Sep 10, 2015 at 11:39:49AM -0700, Junio C Hamano wrote: >> The problem with "empty commit trick" is that it is a commit whose >> sole purpose is to describe the series, and its presence makes it >> clear where the series ends, but the

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 11:39:49AM -0700, Junio C Hamano wrote: > The problem with "empty commit trick" is that it is a commit whose > sole purpose is to describe the series, and its presence makes it > clear where the series ends, but the topology does not tell where > the series begins, so it is

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 02:03:48PM -0700, Jacob Keller wrote: > On Thu, Sep 10, 2015 at 1:09 PM, Philip Oakley wrote: > > From: "Jacob Keller" > >> > >> On Thu, Sep 10, 2015 at 11:44 AM, Junio C Hamano > >> wrote: > >>> > >>>

Re: storing cover letter of a patch series?

Hi Jacob, On 11 September 2015 at 02:30, Chris Packham <judge.pack...@gmail.com> wrote: > On Fri, Sep 11, 2015 at 4:28 AM, Jacob Keller <jacob.kel...@gmail.com> wrote: >> Hey, >> >> does anyone know of any tricks for storing a cover letter for a patch >>

Re: storing cover letter of a patch series?

On Fri, Sep 11, 2015 at 4:28 AM, Jacob Keller <jacob.kel...@gmail.com> wrote: > Hey, > > does anyone know of any tricks for storing a cover letter for a patch > series inside of git somehow? I'd guess the only obvious way currently > is to store it at the top of the seri

Re: storing cover letter of a patch series?

Junio C Hamano writes: > Ideally, I would think that you want that information when the > series is fully cooked and gets merged to a more permanent place in > the log message of the merge commit. At that point, where the > series started may become more clear from the

storing cover letter of a patch series?

Hey, does anyone know of any tricks for storing a cover letter for a patch series inside of git somehow? I'd guess the only obvious way currently is to store it at the top of the series as an empty commit.. but this doesn't get emailed *as* the cover letter... Is there some other way? Would

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 10:41 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> Is there some other way? Would others be interested in such a feature? > > Not me. > >> I get very annoyed when I've written a nice long patch cover letter in >> vim

Re: storing cover letter of a patch series?

Martin Fick writes: > As a Gerrit developer and user, I would like a way to > see/review cover letters in Gerrit. We have had many > internal proposals, most based on git notes, but we have > also used the empty commit trick. It would be nice if there > were some

Re: storing cover letter of a patch series?

Hi Jake, On 2015-09-10 18:28, Jacob Keller wrote: > does anyone know of any tricks for storing a cover letter for a patch > series inside of git somehow? It is not stored as a blob, but I use `git branch --edit-description` to write the cover letter for patch series when I expect a

Re: storing cover letter of a patch series?

+repo-disc...@googlegroups.com (to hit Gerrit developers also) On Thursday, September 10, 2015 09:28:52 AM Jacob Keller <jacob.kel...@gmail.com> wrote: > does anyone know of any tricks for storing a cover letter > for a patch series inside of git somehow? I'd guess the > o

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 11:02 AM, Martin Fick wrote: > On Thursday, September 10, 2015 10:41:54 AM Junio C Hamano > wrote: >> >> I think "should" is too strong here. Yes, you could >> implement that way. It is debatable if it is better, or >> a flat file kept in a

Re: storing cover letter of a patch series?

Jacob Keller writes: > I hadn't thought of separating the cover letter from git-send-email. > That would be suitable for me. Yeah, I said this number of times over time, and I said it once recently in another thread, but I think it was a mistake to allow git-send-email

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 11:44 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> I hadn't thought of separating the cover letter from git-send-email. >> That would be suitable for me. > > Yeah, I said this number of times over time, and I said it

Re: storing cover letter of a patch series?

From: "Johannes Schindelin" <johannes.schinde...@gmx.de> On 2015-09-10 23:00, Jacob Keller wrote: On Thu, Sep 10, 2015 at 11:58 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: On 2015-09-10 18:28, Jacob Keller wrote: does anyone know of any tricks for

Re: storing cover letter of a patch series?

From: "Jacob Keller" On Thu, Sep 10, 2015 at 11:44 AM, Junio C Hamano wrote: Jacob Keller writes: I hadn't thought of separating the cover letter from git-send-email. That would be suitable for me. Yeah, I said this

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 1:09 PM, Philip Oakley wrote: > From: "Jacob Keller" >> >> On Thu, Sep 10, 2015 at 11:44 AM, Junio C Hamano >> wrote: >>> >>> Jacob Keller writes: >>> I hadn't thought of

Re: storing cover letter of a patch series?

On Thu, Sep 10, 2015 at 11:58 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Jake, > > On 2015-09-10 18:28, Jacob Keller wrote: > >> does anyone know of any tricks for storing a cover letter for a patch >> series inside of git somehow? > > I

Re: storing cover letter of a patch series?

Hi Jake, On 2015-09-10 23:00, Jacob Keller wrote: > On Thu, Sep 10, 2015 at 11:58 AM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> >> On 2015-09-10 18:28, Jacob Keller wrote: >> >>> does anyone know of any tricks for storing a cover lett

Re: storing cover letter of a patch series?

Jacob Keller writes: > Is there some other way? Would others be interested in such a feature? Not me. > I get very annoyed when I've written a nice long patch cover letter in > vim before an email and then realize I should fix something else up, > or accidentally cancel