Re: symbol string_list_appendf() unused

2018-05-22 Thread Martin Ă…gren
Hi Ramsay On 22 May 2018 at 02:08, Ramsay Jones wrote: > On 22/05/18 00:59, Junio C Hamano wrote: >> There is a reroll by Martin that ties all the loose ends. > > Ah, OK, sorry for the noise. No worry. Thanks for pointing out the unused function to me. I appreciate

Re: symbol string_list_appendf() unused

2018-05-21 Thread Ramsay Jones
On 22/05/18 00:59, Junio C Hamano wrote: > Ramsay Jones writes: > >> I strongly suspect that I haven't followed the discussion on >> the list closely enough, but your 'ma/unpack-trees-free-msgs' >> branch in 'pu', seems to define string_list_appendf() but then >>

Re: symbol string_list_appendf() unused

2018-05-21 Thread Junio C Hamano
Ramsay Jones writes: > I strongly suspect that I haven't followed the discussion on > the list closely enough, but your 'ma/unpack-trees-free-msgs' > branch in 'pu', seems to define string_list_appendf() but then > never call it. This is despite commit 40ebd6c7b0

symbol string_list_appendf() unused

2018-05-21 Thread Ramsay Jones
Hi Martin, I strongly suspect that I haven't followed the discussion on the list closely enough, but your 'ma/unpack-trees-free-msgs' branch in 'pu', seems to define string_list_appendf() but then never call it. This is despite commit 40ebd6c7b0 ("string-list: provide `string_list_appendf()`",