Re: [git-buildpackage] [PATCH] doc: expand --git-pbuilder-options docs
Thank you! On Fri, Aug 11, 2017 at 3:29 PM, Guido Günther wrote: > Hi, > On Fri, Aug 11, 2017 at 02:51:53PM -0600, Ken Dreyer wrote: >> Give an example of how to use the --git-pbuilder-options option, and >> explain how it interacts with git-pbuilder. >> --- >> docs/manpages/gbp-buildpackage.sgml | 15 ++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/docs/manpages/gbp-buildpackage.sgml >> b/docs/manpages/gbp-buildpackage.sgml >> index 31faabc..f69f17a 100644 >> --- a/docs/manpages/gbp-buildpackage.sgml >> +++ b/docs/manpages/gbp-buildpackage.sgml >> @@ -417,7 +417,20 @@ >> >>Options to pass to pbuilder when building via &git-pbuilder; >> (either >>via --git-pbuilder, >> --git-qemubuilder >> - or the corresponding configuration file options). >> + or the corresponding configuration file options). It does so >> by >> + using the GIT_PBUILDER_OPTIONS environment >> + variable to pass options to &git-pbuilder;. >> + >> + >> + As an example, to tell pbuilder to use an alternate .pbuilderrc >> + file, you may run &gbp-buildpackage; with >> + --git-pbuilder-options="--configfile >> + /tmp/my/pbuilderrc"". See man >> + pbuilder for more options to pass through here. >> + >> + >> + If unset the GIT_PBUILDER_OPTIONS environment >> + variable will be left untouched. >> >> >> > > Pushed (after making some slight docbook fixups). Thanks > -- Guido > >> -- >> 2.13.3 >> >> ___ >> git-buildpackage mailing list >> git-buildpackage@lists.sigxcpu.org >> http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage >> ___ git-buildpackage mailing list git-buildpackage@lists.sigxcpu.org http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage
Re: [git-buildpackage] [PATCH] doc: expand --git-pbuilder-options docs
Hi, On Fri, Aug 11, 2017 at 02:51:53PM -0600, Ken Dreyer wrote: > Give an example of how to use the --git-pbuilder-options option, and > explain how it interacts with git-pbuilder. > --- > docs/manpages/gbp-buildpackage.sgml | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/docs/manpages/gbp-buildpackage.sgml > b/docs/manpages/gbp-buildpackage.sgml > index 31faabc..f69f17a 100644 > --- a/docs/manpages/gbp-buildpackage.sgml > +++ b/docs/manpages/gbp-buildpackage.sgml > @@ -417,7 +417,20 @@ > >Options to pass to pbuilder when building via &git-pbuilder; > (either >via --git-pbuilder, > --git-qemubuilder > - or the corresponding configuration file options). > + or the corresponding configuration file options). It does so by > + using the GIT_PBUILDER_OPTIONS environment > + variable to pass options to &git-pbuilder;. > + > + > + As an example, to tell pbuilder to use an alternate .pbuilderrc > + file, you may run &gbp-buildpackage; with > + --git-pbuilder-options="--configfile > + /tmp/my/pbuilderrc"". See man > + pbuilder for more options to pass through here. > + > + > + If unset the GIT_PBUILDER_OPTIONS environment > + variable will be left untouched. > > > Pushed (after making some slight docbook fixups). Thanks -- Guido > -- > 2.13.3 > > ___ > git-buildpackage mailing list > git-buildpackage@lists.sigxcpu.org > http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage > ___ git-buildpackage mailing list git-buildpackage@lists.sigxcpu.org http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage
Re: [git-buildpackage] [PATCH] doc: expand --git-pbuilder-options docs
On Fri, Aug 11, 2017 at 12:57 PM, Guido Günther wrote: > Looks good. One thing. If the variable is unset gbp is supposed to not > _touch_ GIT_PBUILDER_OPTIONS so a: Whoops, yes! thanks. New patch inbound with your suggestion. > Alternatively we could only have the envvar part there and add another > example to the EXAMPLES section. I like having the really short example here, but the more the better! - Ken ___ git-buildpackage mailing list git-buildpackage@lists.sigxcpu.org http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage
Re: [git-buildpackage] [PATCH] doc: expand --git-pbuilder-options docs
Hi Ken, On Fri, Aug 11, 2017 at 11:04:45AM -0600, Ken Dreyer wrote: > Give an example of how to use the --git-pbuilder-options option, and > explain how it interacts with git-pbuilder. > --- > docs/manpages/gbp-buildpackage.sgml | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/docs/manpages/gbp-buildpackage.sgml > b/docs/manpages/gbp-buildpackage.sgml > index 31faabc..a246e68 100644 > --- a/docs/manpages/gbp-buildpackage.sgml > +++ b/docs/manpages/gbp-buildpackage.sgml > @@ -417,7 +417,13 @@ > >Options to pass to pbuilder when building via &git-pbuilder; > (either >via --git-pbuilder, > --git-qemubuilder > - or the corresponding configuration file options). > + or the corresponding configuration file options). For example, to > + tell pbuilder to use an alternate .pbuilderrc file, you may run > + &gbp-buildpackage; with > + --git-pbuilder-options="--configfile > + /tmp/my/pbuilderrc"". If unset, no > + GIT_PBUILDER_OPTIONS environment > + variable will be passed to git-pbuilder. Looks good. One thing. If the variable is unset gbp is supposed to not _touch_ GIT_PBUILDER_OPTIONS so a: GIT_PBUILDER_OPTIONS="--conf /foo/pbuilderrc" gbp buildpackage … is supposed to work as well. So I'd rather write: … or the corresponding configuration file options). It does so by using the GIT_PBUILDER_OPTIONS environment variable to pass options to &git-pbuilder;. For example, to tell pbuilder to use an alternate .pbuilderrc file, you may run &gbp-buildpackage; with --git-pbuilder-options="--configfile /tmp/my/pbuilderrc"". If unset the GIT_PBUILDER_OPTIONS environment variable will be left untouched. … Alternatively we could only have the envvar part there and add another example to the EXAMPLES section. Cheeers, -- Guido > > > > -- > 2.13.3 > > ___ > git-buildpackage mailing list > git-buildpackage@lists.sigxcpu.org > http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage > ___ git-buildpackage mailing list git-buildpackage@lists.sigxcpu.org http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage