Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fffe470a803e7f7b74c016291e542a0162761209
Commit:     fffe470a803e7f7b74c016291e542a0162761209
Parent:     45a19b0a725a04f3255d9d3da1fca30bb97f1481
Author:     Patrick McHardy <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 7 01:31:32 2007 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Nov 7 04:15:02 2007 -0800

    [VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl
    
    Based on report and patch by Doug Kehn <[EMAIL PROTECTED]>:
    
    vconfig returns the following error when attempting to execute the
    set_ingress_map command:
    
    vconfig: socket or ioctl error for set_ingress_map: Operation not permitted
    
    In vlan.c, vlan_ioctl_handler for SET_VLAN_INGRESS_PRIORITY_CMD
    sets err = -EPERM and calls vlan_dev_set_ingress_priority.
    vlan_dev_set_ingress_priority is a void function so err remains
    at -EPERM and results in the vconfig error (even though the ingress
    map was set).
    
    Fix by setting err = 0 after the vlan_dev_set_ingress_priority call.
    
    Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
---
 net/8021q/vlan.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 3fe4fc8..1037748 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -747,6 +747,7 @@ static int vlan_ioctl_handler(struct net *net, void __user 
*arg)
                vlan_dev_set_ingress_priority(dev,
                                              args.u.skb_priority,
                                              args.vlan_qos);
+               err = 0;
                break;
 
        case SET_VLAN_EGRESS_PRIORITY_CMD:
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to