Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2389d1ef172fc9df01f58265a436919d233fbc27
Commit:     2389d1ef172fc9df01f58265a436919d233fbc27
Parent:     dbeeb816e805091e7cfc03baf36dc40b4adb2bbd
Author:     Oleg Nesterov <[EMAIL PROTECTED]>
AuthorDate: Mon Nov 5 08:58:05 2007 +0100
Committer:  Jens Axboe <[EMAIL PROTECTED]>
CommitDate: Wed Nov 7 09:45:00 2007 +0100

    cfq: fix IOPRIO_CLASS_IDLE accounting
    
    Spotted by Nick <[EMAIL PROTECTED]>, hopefully can explain the second trace 
in
    http://bugzilla.kernel.org/show_bug.cgi?id=9180.
    
    If ->async_idle_cfqq != NULL cfq_put_async_queues() puts it IOPRIO_BE_NR 
times
    in a loop. Fix this.
    
    Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]>
    Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
---
 block/cfq-iosched.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index e47a930..61a3f22 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -2068,9 +2068,10 @@ static void cfq_put_async_queues(struct cfq_data *cfqd)
                        cfq_put_queue(cfqd->async_cfqq[0][i]);
                if (cfqd->async_cfqq[1][i])
                        cfq_put_queue(cfqd->async_cfqq[1][i]);
-               if (cfqd->async_idle_cfqq)
-                       cfq_put_queue(cfqd->async_idle_cfqq);
        }
+
+       if (cfqd->async_idle_cfqq)
+               cfq_put_queue(cfqd->async_idle_cfqq);
 }
 
 static void cfq_exit_queue(elevator_t *e)
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to