Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=10a5a80b3c69d65d66c4d9f4f796725f09bbc8cb
Commit:     10a5a80b3c69d65d66c4d9f4f796725f09bbc8cb
Parent:     7b9b09436b8720621e5594ce25fd25f34d5d42be
Author:     Roel Kluin <[EMAIL PROTECTED]>
AuthorDate: Tue Jan 29 21:14:56 2008 +0100
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Sun Feb 3 04:28:36 2008 -0800

    drivers/net/arm/at91_ether.c: logical/bitand typo in function reset_phy()
    
    include/linux/mii.h:48:#define BMCR_RESET 0x8000
    
    The function reset_phy() is in "#if 0" inactivated code
    
    Replace logical "&&" by bit "&" before BMCR_RESET
    
    Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
---
 drivers/net/arm/at91_ether.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c
index 25b114a..0ae0d83 100644
--- a/drivers/net/arm/at91_ether.c
+++ b/drivers/net/arm/at91_ether.c
@@ -384,7 +384,7 @@ static void reset_phy(struct net_device *dev)
        /* Wait until PHY reset is complete */
        do {
                read_phy(lp->phy_address, MII_BMCR, &bmcr);
-       } while (!(bmcr && BMCR_RESET));
+       } while (!(bmcr & BMCR_RESET));
 
        disable_mdi();
        spin_unlock_irq(&lp->lock);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to