Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=70eee74b70c1a8485ec5f2bafa13dbc66fab6e02
Commit:     70eee74b70c1a8485ec5f2bafa13dbc66fab6e02
Parent:     6892b75e60557a48c01d57ba320419a9e2ce9846
Author:     Balbir Singh <[EMAIL PROTECTED]>
AuthorDate: Fri Feb 22 13:25:53 2008 +0530
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Mon Feb 25 16:34:17 2008 +0100

    sched: remove duplicate code from sched_fair.c
    
    pick_task_entity() duplicates existing code. This functionality can be
    easily obtained using rb_last(). Avoid code duplication by using rb_last().
    
    Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
---
 kernel/sched_fair.c |   15 ++++++---------
 1 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 6c091d6..7abad50 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -202,16 +202,13 @@ static struct sched_entity *__pick_next_entity(struct 
cfs_rq *cfs_rq)
 
 static inline struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq)
 {
-       struct rb_node **link = &cfs_rq->tasks_timeline.rb_node;
-       struct sched_entity *se = NULL;
-       struct rb_node *parent;
-
-       while (*link) {
-               parent = *link;
-               se = rb_entry(parent, struct sched_entity, run_node);
-               link = &parent->rb_right;
-       }
+       struct rb_node *last;
+       struct sched_entity *se;
 
+       last = rb_last(&cfs_rq->tasks_timeline);
+       if (!last)
+               return NULL;
+       se = rb_entry(last, struct sched_entity, run_node);
        return se;
 }
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to