Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c1666e663d8443f57c1c6b0acac70c3fbaea9014
Commit:     c1666e663d8443f57c1c6b0acac70c3fbaea9014
Parent:     8af03e782cae1e0a0f530ddd22301cdd12cf9dc0
Author:     Harvey Harrison <[EMAIL PROTECTED]>
AuthorDate: Thu Jan 31 22:05:43 2008 +0100
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Thu Jan 31 22:05:43 2008 +0100

    x86: fix sparse warnings in intel_cacheinfo.c
    
    arch/x86/kernel/cpu/intel_cacheinfo.c:355:7: warning: symbol 'i' shadows an 
earlier one
    arch/x86/kernel/cpu/intel_cacheinfo.c:296:39: originally declared here
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:18: warning: incorrect type in 
argument 2 (different signedness)
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:18:    expected unsigned int *eax
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:18:    got int *
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:28: warning: incorrect type in 
argument 3 (different signedness)
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:28:    expected unsigned int *ebx
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:28:    got int *
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:38: warning: incorrect type in 
argument 4 (different signedness)
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:38:    expected unsigned int *ecx
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:38:    got int *
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:48: warning: incorrect type in 
argument 5 (different signedness)
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:48:    expected unsigned int *edx
    arch/x86/kernel/cpu/intel_cacheinfo.c:367:48:    got int *
    
    Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
---
 arch/x86/kernel/cpu/intel_cacheinfo.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c 
b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 8b4507b..1b88986 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -352,8 +352,8 @@ unsigned int __cpuinit init_intel_cacheinfo(struct 
cpuinfo_x86 *c)
         */
        if ((num_cache_leaves == 0 || c->x86 == 15) && c->cpuid_level > 1) {
                /* supports eax=2  call */
-               int i, j, n;
-               int regs[4];
+               int j, n;
+               unsigned int regs[4];
                unsigned char *dp = (unsigned char *)regs;
                int only_trace = 0;
 
@@ -368,7 +368,7 @@ unsigned int __cpuinit init_intel_cacheinfo(struct 
cpuinfo_x86 *c)
 
                        /* If bit 31 is set, this is an unknown format */
                        for ( j = 0 ; j < 3 ; j++ ) {
-                               if ( regs[j] < 0 ) regs[j] = 0;
+                               if (regs[j] & (1 << 31)) regs[j] = 0;
                        }
 
                        /* Byte 0 is level count, not a descriptor */
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to