[ALSA] pcm - Fix zero-division in 32bit compat layer

[Linux Kernel Mailing List]

tree 79b0a39ef01f45c25966c7bce3ab35d8a5a183db
parent e0c93cf311b3eaa04bfb5769cff38861d4e748c8
author Takashi Iwai <[EMAIL PROTECTED]> Thu, 25 Aug 2005 19:51:47 +0200
committer Jaroslav Kysela <[EMAIL PROTECTED]> Tue, 30 Aug 2005 08:47:40 +0200

[ALSA] pcm - Fix zero-division in 32bit compat layer

PCM Midlevel
Fixed zero-division bug in PCM 32bit compat layer.

Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]>

 sound/core/pcm_compat.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c
--- a/sound/core/pcm_compat.c
+++ b/sound/core/pcm_compat.c
@@ -144,7 +144,7 @@ static int snd_pcm_ioctl_sw_params_compa
        err = snd_pcm_sw_params(substream, &params);
        if (err < 0)
                return err;
-       if (put_user(boundary, &src->boundary))
+       if (boundary && put_user(boundary, &src->boundary))
                return -EFAULT;
        return err;
 }
@@ -252,8 +252,11 @@ static int snd_pcm_ioctl_hw_params_compa
                goto error;
        }
 
-       if (! refine)
-               runtime->boundary = recalculate_boundary(runtime);
+       if (! refine) {
+               unsigned int new_boundary = recalculate_boundary(runtime);
+               if (new_boundary)
+                       runtime->boundary = new_boundary;
+       }
  error:
        kfree(data);
        return err;
@@ -408,6 +411,8 @@ static int snd_pcm_ioctl_sync_ptr_compat
        status = runtime->status;
        control = runtime->control;
        boundary = recalculate_boundary(runtime);
+       if (! boundary)
+               boundary = 0x7fffffff;
        snd_pcm_stream_lock_irq(substream);
        /* FIXME: we should consider the boundary for the sync from app */
        if (!(sflags & SNDRV_PCM_SYNC_PTR_APPL))
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html