Gitweb:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=da7cd59ab9c8ed233df4809f6c8c90c636f676c7
Commit: da7cd59ab9c8ed233df4809f6c8c90c636f676c7
Parent: 29059d12e0c7f349aca6993acac20c5efbe13b81
Author: Herbert Xu <[EMAIL PROTECTED]>
AuthorDate: Sat May 19 14:51:00 2007 +1000
Committer: Herbert Xu <[EMAIL PROTECTED]>
CommitDate: Sat May 19 14:51:00 2007 +1000
[CRYPTO] api: Read module pointer before freeing algorithm
The function crypto_mod_put first frees the algorithm and then drops
the reference to its module. Unfortunately we read the module pointer
which after freeing the algorithm and that pointer sits inside the
object that we just freed.
So this patch reads the module pointer out before we free the object.
Thanks to Luca Tettamanti for reporting this.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
crypto/api.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/crypto/api.c b/crypto/api.c
index 55af8bb..33734fd 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -48,8 +48,10 @@ EXPORT_SYMBOL_GPL(crypto_mod_get);
void crypto_mod_put(struct crypto_alg *alg)
{
+ struct module *module = alg->cra_module;
+
crypto_alg_put(alg);
- module_put(alg->cra_module);
+ module_put(module);
}
EXPORT_SYMBOL_GPL(crypto_mod_put);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
