Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f1673ca52c04f1b311abe03fd67cd4d650d19435
Commit:     f1673ca52c04f1b311abe03fd67cd4d650d19435
Parent:     c749b01351d249a924d1dd061dd1431bd3ad0579
Author:     Denis V. Lunev <[EMAIL PROTECTED]>
AuthorDate: Mon Oct 15 12:53:13 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Mon Oct 15 12:53:13 2007 -0700

    [INET]: kmalloc+memset -> kzalloc in frag_alloc_queue
    
    kmalloc + memset -> kzalloc in frag_alloc_queue
    
    Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
---
 net/ipv4/ip_fragment.c                  |    7 +------
 net/ipv6/netfilter/nf_conntrack_reasm.c |    7 +++----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c
index 3171ec0..443b3f8 100644
--- a/net/ipv4/ip_fragment.c
+++ b/net/ipv4/ip_fragment.c
@@ -144,7 +144,7 @@ static __inline__ void ip4_frag_free(struct inet_frag_queue 
*q)
 
 static __inline__ struct ipq *frag_alloc_queue(void)
 {
-       struct ipq *qp = kmalloc(sizeof(struct ipq), GFP_ATOMIC);
+       struct ipq *qp = kzalloc(sizeof(struct ipq), GFP_ATOMIC);
 
        if (!qp)
                return NULL;
@@ -265,15 +265,10 @@ static struct ipq *ip_frag_create(struct iphdr *iph, u32 
user)
                goto out_nomem;
 
        qp->protocol = iph->protocol;
-       qp->q.last_in = 0;
        qp->id = iph->id;
        qp->saddr = iph->saddr;
        qp->daddr = iph->daddr;
        qp->user = user;
-       qp->q.len = 0;
-       qp->q.meat = 0;
-       qp->q.fragments = NULL;
-       qp->iif = 0;
        qp->peer = sysctl_ipfrag_max_dist ? inet_getpeer(iph->saddr, 1) : NULL;
 
        /* Initialize a timer for this entry. */
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c 
b/net/ipv6/netfilter/nf_conntrack_reasm.c
index bf6f2f0..726fafd 100644
--- a/net/ipv6/netfilter/nf_conntrack_reasm.c
+++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
@@ -137,9 +137,10 @@ static void nf_frag_free(struct inet_frag_queue *q)
 
 static inline struct nf_ct_frag6_queue *frag_alloc_queue(void)
 {
-       struct nf_ct_frag6_queue *fq = kmalloc(sizeof(struct 
nf_ct_frag6_queue), GFP_ATOMIC);
+       struct nf_ct_frag6_queue *fq;
 
-       if (!fq)
+       fq = kzalloc(sizeof(struct nf_ct_frag6_queue), GFP_ATOMIC);
+       if (fq == NULL)
                return NULL;
        atomic_add(sizeof(struct nf_ct_frag6_queue), &nf_frags.mem);
        return fq;
@@ -230,8 +231,6 @@ nf_ct_frag6_create(unsigned int hash, __be32 id, struct 
in6_addr *src,                                 str
                goto oom;
        }
 
-       memset(fq, 0, sizeof(struct nf_ct_frag6_queue));
-
        fq->id = id;
        ipv6_addr_copy(&fq->saddr, src);
        ipv6_addr_copy(&fq->daddr, dst);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to