Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=22117ea4fef4ea1c7d97c4d68c02c96c268a511b Commit: 22117ea4fef4ea1c7d97c4d68c02c96c268a511b Parent: 06c7af563d925d04961ce70cd9154fad8e2750c8 Author: Andy Whitcroft <[EMAIL PROTECTED]> AuthorDate: Tue Aug 21 21:23:39 2007 -0700 Committer: David S. Miller <[EMAIL PROTECTED]> CommitDate: Tue Aug 21 21:23:39 2007 -0700
[IRDA] irda_nl_get_mode: always results in failure It seems an extraneous trailing ';' has slipped in to the error handling for a name registration failure causing the error path to trigger unconditionally. Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/irda/irnetlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/irnetlink.c b/net/irda/irnetlink.c index 694ea4d..1e429c9 100644 --- a/net/irda/irnetlink.c +++ b/net/irda/irnetlink.c @@ -106,7 +106,7 @@ static int irda_nl_get_mode(struct sk_buff *skb, struct genl_info *info) } if(nla_put_string(msg, IRDA_NL_ATTR_IFNAME, - dev->name)); + dev->name)) goto err_out; if(nla_put_u32(msg, IRDA_NL_ATTR_MODE, irlap->mode)) - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html