Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d133ccbdc30c7f86459519cec1126d6473762b10 Commit: d133ccbdc30c7f86459519cec1126d6473762b10 Parent: d39badf05b52f99169b22ce324fd31c8b44a0473 Author: Satyam Sharma <[EMAIL PROTECTED]> AuthorDate: Fri Aug 10 15:28:10 2007 -0700 Committer: David S. Miller <[EMAIL PROTECTED]> CommitDate: Wed Oct 10 16:48:02 2007 -0700
[NET] netconsole: Remove bogus check Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is set by netpoll_setup(), which is called by init_netconsole() before register_console(), so write_msg() cannot be triggered unless netpoll_setup() successfully set np.dev. Also np.dev cannot go away from under us, because netpoll_setup() grabs us reference on it. So let's remove the bogus check. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Acked-by: Keiichi Kii <[EMAIL PROTECTED]> Acked-by: Matt Mackall <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- drivers/net/netconsole.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index f1c2a2d..2c2aef1 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -67,9 +67,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len) int frag, left; unsigned long flags; - if (!np.dev) - return; - local_irq_save(flags); for (left = len; left;) { - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html