Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=dc4e4207ed7dc256fed1626fbf087cb199cd1945
Commit:     dc4e4207ed7dc256fed1626fbf087cb199cd1945
Parent:     aafa1955501955bf4e53b72fee0be9f35b711b9d
Author:     Kim Phillips <[EMAIL PROTECTED]>
AuthorDate: Fri Feb 1 18:09:58 2008 -0600
Committer:  Kumar Gala <[EMAIL PROTECTED]>
CommitDate: Tue Feb 5 23:38:27 2008 -0600

    [POWERPC] FSL: fix mpc83xx_spi device registration
    
    calling platform_device_register after platform_device_alloc causes
    this:
    
    kobject (c3841a70): tried to init an initialized object, something is 
seriously wrong.
    Call Trace:
    [c381fe20] [c0007bb8] show_stack+0x3c/0x194 (unreliable)
    [c381fe50] [c01322a8] kobject_init+0xb8/0xbc
    [c381fe60] [c01591cc] device_initialize+0x30/0x9c
    [c381fe80] [c015ee34] platform_device_register+0x1c/0x34
    [c381fea0] [c02f1fe0] of_fsl_spi_probe+0x21c/0x22c
    [c381ff30] [c02f2044] fsl_spi_init+0x54/0x160
    [c381ff60] [c02f3924] 
__machine_initcall_mpc832x_rdb_mpc832x_spi_init+0x120/0x138
    [c381ff70] [c02e61b4] kernel_init+0x98/0x284
    [c381fff0] [c000f740] kernel_thread+0x44/0x60
    
    fixed by calling platform_device_add (second half of
    platform_device_register) instead.
    
    Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
    Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>
---
 arch/powerpc/sysdev/fsl_soc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index e48b20e..2c5388c 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -1342,7 +1342,7 @@ static int __init of_fsl_spi_probe(char *type, char 
*compatible, u32 sysclk,
                if (ret)
                        goto unreg;
 
-               ret = platform_device_register(pdev);
+               ret = platform_device_add(pdev);
                if (ret)
                        goto unreg;
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to