Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bd4c2edc90c020ba5573da5dbd796fd6ab78692b
Commit:     bd4c2edc90c020ba5573da5dbd796fd6ab78692b
Parent:     ca55f0570304dd625370f85097fec81dd5a92090
Author:     Julia Lawall <[EMAIL PROTECTED]>
AuthorDate: Thu Dec 13 15:56:07 2007 -0800
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Thu Dec 20 17:13:50 2007 +1100

    [POWERPC] arch/ppc: Remove an unnecessary pci_dev_put
    
    Remove an unnecessary pci_dev_put.  pci_dev_put is called implicitly
    by the subsequent call to pci_get_device.
    
    The problem was detected using the following semantic patch, and
    corrected by hand.
    
    @@
    expression dev;
    expression E;
    @@
    
    - pci_dev_put(dev)
       ... when != dev = E
    - pci_get_device(...,dev)
    
    Signed-off-by: Julia Lawall <[EMAIL PROTECTED]>
    Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
---
 arch/ppc/platforms/prep_pci.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/ppc/platforms/prep_pci.c b/arch/ppc/platforms/prep_pci.c
index 1df3150..8ed433e 100644
--- a/arch/ppc/platforms/prep_pci.c
+++ b/arch/ppc/platforms/prep_pci.c
@@ -1099,7 +1099,6 @@ prep_pib_init(void)
                                pci_write_config_byte(dev, 0x43, reg);
                        }
                }
-               pci_dev_put(dev);
        }
 
        if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND,
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to