Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c8e91b0a8fc8493e3bf3efcb3c8f866e9453cf1c
Commit:     c8e91b0a8fc8493e3bf3efcb3c8f866e9453cf1c
Parent:     76246808248ac4c94ec3b57e37f35f8e05dfa0b3
Author:     Dhaval Giani <[EMAIL PROTECTED]>
AuthorDate: Fri Oct 12 15:12:31 2007 +0530
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:56:24 2007 -0400

    [SCSI] gdth: fix CONFIG_ISA build failure
    
    drivers/scsi/gdth.c: In function ‘gdth_search_dev’:
    drivers/scsi/gdth.c:646: warning: ‘pci_find_device’ is deprecated
    (declared at include/linux/pci.h:482)
    drivers/scsi/gdth.c: In function ‘gdth_init_isa’:
    drivers/scsi/gdth.c:857: error: ‘gdth_irq_tab’ undeclared (first use in
    this function)
    drivers/scsi/gdth.c:857: error: (Each undeclared identifier is reported
    only once
    drivers/scsi/gdth.c:857: error: for each function it appears in.)
    drivers/scsi/gdth.c: In function ‘gdth_copy_internal_data’:
    drivers/scsi/gdth.c:2362: warning: unused variable ‘sg’
    
    Looking into the code I notice that gdth_irq_tab is not declared with
    CONFIG_ISA=y and !CONFIG_EISA.
    
    The values seem to be same in 2.6.23 (I am not sure why it has been put
    with #ifdefs in -mm) so I have just modified the #ifdef to take care of
    CONFIG_ISA as well.
    
    Signed-off-by: Dhaval Giani <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/gdth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 0153d1d..e8010a7 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -288,7 +288,7 @@ static struct timer_list gdth_timer;
 #ifdef CONFIG_ISA
 static unchar   gdth_drq_tab[4] = {5,6,7,7};            /* DRQ table */
 #endif
-#ifdef CONFIG_EISA
+#if defined(CONFIG_EISA) || defined(CONFIG_ISA)
 static unchar   gdth_irq_tab[6] = {0,10,11,12,14,0};    /* IRQ table */
 #endif
 static unchar   gdth_polling;                           /* polling if TRUE */
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to