Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3a43e69ce50d467ded2f17f6e571e831d3677ab5
Commit:     3a43e69ce50d467ded2f17f6e571e831d3677ab5
Parent:     fd0b45dfd1858c6b49d06355a460bcf36d654c06
Author:     FUJITA Tomonori <[EMAIL PROTECTED]>
AuthorDate: Tue Jan 8 23:07:01 2008 +0900
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Wed Jan 9 15:06:07 2008 -0600

    [SCSI] qla1280: fix 32 bit segment code
    
    There's an error remaining in the 32 bit descriptor code after the
    conversion to dma accessors:  req_cnt is left uninitialised.
    
    qla1280_32bit_start_scsi gives the following warnings:
    
    drivers/scsi/qla1280.c: In function 'qla1280_32bit_start_scsi':
    drivers/scsi/qla1280.c:3044: warning: unused variable 'dma_handle'
    drivers/scsi/qla1280.c: In function 'qla1280_queuecommand':
    drivers/scsi/qla1280.c:3060: warning: 'req_cnt' is used uninitialized in 
this function
    drivers/scsi/qla1280.c:3042: note: 'req_cnt' was declared here
    
    Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/qla1280.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 146d540..2886407 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -3041,7 +3041,6 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct 
srb * sp)
        int cnt;
        int req_cnt;
        int seg_cnt;
-       dma_addr_t dma_handle;
        u8 dir;
 
        ENTER("qla1280_32bit_start_scsi");
@@ -3050,6 +3049,7 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct 
srb * sp)
                cmd->cmnd[0]);
 
        /* Calculate number of entries and segments required. */
+       req_cnt = 1;
        seg_cnt = scsi_dma_map(cmd);
        if (seg_cnt) {
                /*
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to