Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=65fecc77f3c47c5e8758d133b8ec47dcc16ed207
Commit:     65fecc77f3c47c5e8758d133b8ec47dcc16ed207
Parent:     a8e14fec164cc01d8dfb18760ee9bddd91e127c2
Author:     David Somayajulu <[EMAIL PROTECTED]>
AuthorDate: Thu Feb 21 03:43:00 2008 -0800
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Fri Feb 22 17:14:12 2008 -0600

    [SCSI] qla4xxx: fix up residual handling
    
    the check in the residual case has an incorrect test of scsi_status
    (the logic is reversed, it should be scsi_status != 0 instead of
    !scsi_status.  Since we checked a few lines above that scsi_status was
    non-zero, just eliminate this test
    
    Signed-off-by: David C Somayajulu <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/qla4xxx/ql4_isr.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_isr.c b/drivers/scsi/qla4xxx/ql4_isr.c
index 0f029d0..fc84db4 100644
--- a/drivers/scsi/qla4xxx/ql4_isr.c
+++ b/drivers/scsi/qla4xxx/ql4_isr.c
@@ -100,8 +100,7 @@ static void qla4xxx_status_entry(struct scsi_qla_host *ha,
 
                if (sts_entry->iscsiFlags &ISCSI_FLAG_RESIDUAL_UNDER) {
                        scsi_set_resid(cmd, residual);
-                       if (!scsi_status && ((scsi_bufflen(cmd) - residual) <
-                               cmd->underflow)) {
+                       if ((scsi_bufflen(cmd) - residual) < cmd->underflow) {
 
                                cmd->result = DID_ERROR << 16;
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to