Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ce3ba1399d2ba81b3699a82649df0cd8223c6662 Commit: ce3ba1399d2ba81b3699a82649df0cd8223c6662 Parent: be63a21c9573fbf88106ff0f030da5974551257b Author: Matti Linnanvuori <[EMAIL PROTECTED]> AuthorDate: Tue Jan 15 06:25:27 2008 -0800 Committer: Jeff Garzik <[EMAIL PROTECTED]> CommitDate: Fri Jan 18 14:41:49 2008 -0500
Documentation: add a guideline for hard_start_xmit method Add a guideline not to modify SKBs. Signed-off-by: Matti Linnanvuori <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- Documentation/networking/driver.txt | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Documentation/networking/driver.txt b/Documentation/networking/driver.txt index 4f7da5a..ea72d2e 100644 --- a/Documentation/networking/driver.txt +++ b/Documentation/networking/driver.txt @@ -61,7 +61,10 @@ Transmit path guidelines: 2) Do not forget to update netdev->trans_start to jiffies after each new tx packet is given to the hardware. -3) Do not forget that once you return 0 from your hard_start_xmit +3) A hard_start_xmit method must not modify the shared parts of a + cloned SKB. + +4) Do not forget that once you return 0 from your hard_start_xmit method, it is your driver's responsibility to free up the SKB and in some finite amount of time. - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html