Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=52cb1c2b70d9d2a81e842b90456b7a8158541ffd
Commit:     52cb1c2b70d9d2a81e842b90456b7a8158541ffd
Parent:     fe6d3a4049ec9d859d75ddfcc6865a0f58178924
Author:     Andy Fleming <[EMAIL PROTECTED]>
AuthorDate: Wed Jul 18 01:06:28 2007 -0500
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Tue Jul 24 16:28:41 2007 -0400

    Fix error checking in Vitesse IRQ config
    
    phy_read() returns a negative number if there's an error, but the
    error-checking code in the Vitesse driver's config_intr function
    triggers if phy_read() returns non-zero.  Correct that.
    
    Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 drivers/net/phy/vitesse.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
index 6a53856..8874497 100644
--- a/drivers/net/phy/vitesse.c
+++ b/drivers/net/phy/vitesse.c
@@ -109,7 +109,7 @@ static int vsc824x_config_intr(struct phy_device *phydev)
                 */
                err = phy_read(phydev, MII_VSC8244_ISTAT);
 
-               if (err)
+               if (err < 0)
                        return err;
 
                err = phy_write(phydev, MII_VSC8244_IMASK, 0);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to