Fix ThinkPad T42 poweroff failure introduced by by PM: Introduce pm_power_off_prepare

2007-07-26 Thread Linux Kernel Mailing List
Gitweb: 
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=58b3b71dfaaecbf7cff1fe10c049d663f0313e5f
Commit: 58b3b71dfaaecbf7cff1fe10c049d663f0313e5f
Parent: 602033ed5907a59ce86f709082a35be047743a86
Author: Rafael J. Wysocki [EMAIL PROTECTED]
AuthorDate: Thu Jul 26 16:29:55 2007 +0200
Committer:  Linus Torvalds [EMAIL PROTECTED]
CommitDate: Thu Jul 26 12:13:06 2007 -0700

Fix ThinkPad T42 poweroff failure introduced by by PM: Introduce 
pm_power_off_prepare

Commit bd804eba1c8597cbb7cd5a5f9fe886aae16a079a (PM: Introduce
pm_power_off_prepare) caused problems in the poweroff path, as reported by
YOSHIFUJI Hideaki / 吉藤英明.

Generally, sysdev_shutdown() should be called after the ACPI preparation for
powering the system off.  To make it happen, we can separate 
sysdev_shutdown()
from device_shutdown() and call it directly wherever necessary.

Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]
Tested-by: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
---
 drivers/base/power/shutdown.c |2 --
 include/linux/device.h|3 +++
 kernel/power/disk.c   |1 +
 kernel/sys.c  |3 +++
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/shutdown.c b/drivers/base/power/shutdown.c
index a47ee1b..56e8eaa 100644
--- a/drivers/base/power/shutdown.c
+++ b/drivers/base/power/shutdown.c
@@ -44,7 +44,5 @@ void device_shutdown(void)
dev-driver-shutdown(dev);
}
}
-
-   sysdev_shutdown();
 }
 
diff --git a/include/linux/device.h b/include/linux/device.h
index d9f0a57..3a38d1f 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -551,6 +551,9 @@ extern void put_device(struct device * dev);
 /* drivers/base/power/shutdown.c */
 extern void device_shutdown(void);
 
+/* drivers/base/sys.c */
+extern void sysdev_shutdown(void);
+
 
 /* drivers/base/firmware.c */
 extern int __must_check firmware_register(struct kset *);
diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 324ac01..eb72255 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -216,6 +216,7 @@ int hibernation_platform_enter(void)
 * sleep state after all
 */
error = hibernation_ops-prepare();
+   sysdev_shutdown();
if (!error)
error = hibernation_ops-enter();
} else {
diff --git a/kernel/sys.c b/kernel/sys.c
index 08562f4..14f8adc 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -804,6 +804,7 @@ static void kernel_restart_prepare(char *cmd)
blocking_notifier_call_chain(reboot_notifier_list, SYS_RESTART, cmd);
system_state = SYSTEM_RESTART;
device_shutdown();
+   sysdev_shutdown();
 }
 
 /**
@@ -860,6 +861,7 @@ void kernel_shutdown_prepare(enum system_states state)
 void kernel_halt(void)
 {
kernel_shutdown_prepare(SYSTEM_HALT);
+   sysdev_shutdown();
printk(KERN_EMERG System halted.\n);
machine_halt();
 }
@@ -876,6 +878,7 @@ void kernel_power_off(void)
kernel_shutdown_prepare(SYSTEM_POWER_OFF);
if (pm_power_off_prepare)
pm_power_off_prepare();
+   sysdev_shutdown();
printk(KERN_EMERG Power down.\n);
machine_power_off();
 }
-
To unsubscribe from this list: send the line unsubscribe git-commits-head in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


PM: Introduce pm_power_off_prepare

2007-07-19 Thread Linux Kernel Mailing List
Gitweb: 
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bd804eba1c8597cbb7cd5a5f9fe886aae16a079a
Commit: bd804eba1c8597cbb7cd5a5f9fe886aae16a079a
Parent: d7372cdf6938ccea23ec9fc68970702fed9ec3c8
Author: Rafael J. Wysocki [EMAIL PROTECTED]
AuthorDate: Thu Jul 19 01:47:40 2007 -0700
Committer:  Linus Torvalds [EMAIL PROTECTED]
CommitDate: Thu Jul 19 10:04:42 2007 -0700

PM: Introduce pm_power_off_prepare

Introduce the pm_power_off_prepare() callback that can be registered by the
interested platforms in analogy with pm_idle() and pm_power_off(), used for
preparing the system to power off (needed by ACPI).

This allows us to drop acpi_sysclass and device_acpi that are only defined 
in
order to register the ACPI power off preparation callback, which is needed 
by
pm_power_off() registered in a much different way.

Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]
Acked-by: Pavel Machek [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
---
 drivers/acpi/sleep/poweroff.c |   38 +-
 include/linux/pm.h|1 +
 kernel/sys.c  |9 +
 3 files changed, 19 insertions(+), 29 deletions(-)

diff --git a/drivers/acpi/sleep/poweroff.c b/drivers/acpi/sleep/poweroff.c
index 240dde9..39e40d5 100644
--- a/drivers/acpi/sleep/poweroff.c
+++ b/drivers/acpi/sleep/poweroff.c
@@ -39,7 +39,13 @@ int acpi_sleep_prepare(u32 acpi_state)
 
 #ifdef CONFIG_PM
 
-void acpi_power_off(void)
+static void acpi_power_off_prepare(void)
+{
+   /* Prepare to power off the system */
+   acpi_sleep_prepare(ACPI_STATE_S5);
+}
+
+static void acpi_power_off(void)
 {
/* acpi_sleep_prepare(ACPI_STATE_S5) should have already been called */
printk(%s called\n, __FUNCTION__);
@@ -48,27 +54,6 @@ void acpi_power_off(void)
acpi_enter_sleep_state(ACPI_STATE_S5);
 }
 
-static int acpi_shutdown(struct sys_device *x)
-{
-   switch (system_state) {
-   case SYSTEM_POWER_OFF:
-   /* Prepare to power off the system */
-   return acpi_sleep_prepare(ACPI_STATE_S5);
-   default:
-   return 0;
-   }
-}
-
-static struct sysdev_class acpi_sysclass = {
-   set_kset_name(acpi),
-   .shutdown = acpi_shutdown
-};
-
-static struct sys_device device_acpi = {
-   .id = 0,
-   .cls = acpi_sysclass,
-};
-
 static int acpi_poweroff_init(void)
 {
if (!acpi_disabled) {
@@ -78,13 +63,8 @@ static int acpi_poweroff_init(void)
status =
acpi_get_sleep_type_data(ACPI_STATE_S5, type_a, type_b);
if (ACPI_SUCCESS(status)) {
-   int error;
-   error = sysdev_class_register(acpi_sysclass);
-   if (!error)
-   error = sysdev_register(device_acpi);
-   if (!error)
-   pm_power_off = acpi_power_off;
-   return error;
+   pm_power_off_prepare = acpi_power_off_prepare;
+   pm_power_off = acpi_power_off;
}
}
return 0;
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 2735b7c..ad3cc2e 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -101,6 +101,7 @@ struct pm_dev
  */
 extern void (*pm_idle)(void);
 extern void (*pm_power_off)(void);
+extern void (*pm_power_off_prepare)(void);
 
 typedef int __bitwise suspend_state_t;
 
diff --git a/kernel/sys.c b/kernel/sys.c
index 18987c7..d40e40a 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -100,6 +100,13 @@ struct pid *cad_pid;
 EXPORT_SYMBOL(cad_pid);
 
 /*
+ * If set, this is used for preparing the system to power off.
+ */
+
+void (*pm_power_off_prepare)(void);
+EXPORT_SYMBOL(pm_power_off_prepare);
+
+/*
  * Notifier list for kernel code which wants to be called
  * at shutdown. This is used to stop any idling DMA operations
  * and the like. 
@@ -867,6 +874,8 @@ EXPORT_SYMBOL_GPL(kernel_halt);
 void kernel_power_off(void)
 {
kernel_shutdown_prepare(SYSTEM_POWER_OFF);
+   if (pm_power_off_prepare)
+   pm_power_off_prepare();
printk(KERN_EMERG Power down.\n);
machine_power_off();
 }
-
To unsubscribe from this list: send the line unsubscribe git-commits-head in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html