Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5d44b414daa8c1d8551aed6130d86d54175db43f
Commit:     5d44b414daa8c1d8551aed6130d86d54175db43f
Parent:     332673257056d8be8a69d759eda90a799af5472d
Author:     Harvey Harrison <[EMAIL PROTECTED]>
AuthorDate: Fri Feb 15 13:41:32 2008 -0800
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Wed Feb 20 12:12:47 2008 -0500

    ata: fix sparse warning in libata.h
    
    Avoids lots of these, also is more readable.
    include/linux/libata.h:1210:13: warning: potentially expensive pointer 
subtraction
    
    Change the subtraction to addition on the other side of the comparison.
    
    Thanks to Christer Weinigel for the suggestion.
    
    Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
    Acked-by: Tejun Heo <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 include/linux/libata.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/libata.h b/include/linux/libata.h
index 2e098f9..ce7603a 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1197,7 +1197,7 @@ static inline struct ata_link *ata_port_next_link(struct 
ata_link *link)
                return ap->pmp_link;
        }
 
-       if (++link - ap->pmp_link < ap->nr_pmp_links)
+       if (++link < ap->nr_pmp_links + ap->pmp_link)
                return link;
        return NULL;
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to