Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8a32352661cc8e942897d205ba18f871ef7be597 Commit: 8a32352661cc8e942897d205ba18f871ef7be597 Parent: 34dd962b748bdb4f96fc5e6e69dc66522924f489 Author: Maciej W. Rozycki <[EMAIL PROTECTED]> AuthorDate: Tue May 29 16:12:22 2007 +0100 Committer: Jeff Garzik <[EMAIL PROTECTED]> CommitDate: Wed May 30 09:52:48 2007 -0400
defxx: Fix the handling of ioremap() failures If ioremap_nocache() is unfortunate enough to fail, the error code is not set correctly leading to a false success from dfx_register(). This change fixes the problem. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/net/defxx.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/defxx.c b/drivers/net/defxx.c index 571d82f..7df23dc 100644 --- a/drivers/net/defxx.c +++ b/drivers/net/defxx.c @@ -566,6 +566,7 @@ static int __devinit dfx_register(struct device *bdev) bp->base.mem = ioremap_nocache(bar_start, bar_len); if (!bp->base.mem) { printk(KERN_ERR "%s: Cannot map MMIO\n", print_name); + err = -ENOMEM; goto err_out_region; } } else { - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html