Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=46f26c362d5109459f04f99e93fc0413d88516c8
Commit:     46f26c362d5109459f04f99e93fc0413d88516c8
Parent:     d3bb03438c58b2a00f07a59175d4156a9952d825
Author:     Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
AuthorDate: Fri Jan 25 22:17:09 2008 +0100
Committer:  Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
CommitDate: Fri Jan 25 22:17:09 2008 +0100

    ide: fix registers loading order for WIN_SMART in execute_drive_cmd()
    
    Fix registers loading order for REQ_TYPE_ATA_CMD request with WIN_SMART
    command in execute_drive_cmd() (load IDE_FEATURE_REG and IDE_SECTOR_REG
    before loading IDE_LCYL_REG and IDE_HCYL_REG).
    
    It shouldn't affect anything (just a usual paranoia to separate changes
    which change the way in which hardware is accessed from code cleanups).
    
    Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
    Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
 drivers/ide/ide-io.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 4ea8419..c616c9f 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -932,10 +932,10 @@ static ide_startstop_t execute_drive_cmd (ide_drive_t 
*drive,
                printk("xx=0x%02x\n", args[3]);
 #endif
                if (args[0] == WIN_SMART) {
-                       hwif->OUTB(0x4f, IDE_LCYL_REG);
-                       hwif->OUTB(0xc2, IDE_HCYL_REG);
                        hwif->OUTB(args[2],IDE_FEATURE_REG);
                        hwif->OUTB(args[1],IDE_SECTOR_REG);
+                       hwif->OUTB(0x4f, IDE_LCYL_REG);
+                       hwif->OUTB(0xc2, IDE_HCYL_REG);
                        ide_cmd(drive, args[0], args[3], &drive_cmd_intr);
                        return ide_started;
                }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to