Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7a9eeb2fa1b3a3a83670b9ba08dd396beedb88f8 Commit: 7a9eeb2fa1b3a3a83670b9ba08dd396beedb88f8 Parent: 12998096cc48563a04ca751965ba17c3f73a5461 Author: Stefan Richter <[EMAIL PROTECTED]> AuthorDate: Tue Mar 20 22:43:22 2007 +0100 Committer: Stefan Richter <[EMAIL PROTECTED]> CommitDate: Fri Mar 23 10:55:25 2007 +0100
ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion The networking subsystem has been converted from class_device to device but ieee1394 hasn't. This results in a 100% reproducible NULL pointer dereference if the ohci1394 driver module is unloaded while the eth1394 module is still loaded. http://lkml.org/lkml/2006/11/16/147 http://lkml.org/lkml/2007/3/14/4 This is a regression in 2.6.21-rc1. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> Tested-by: Ismail Dönmez <[EMAIL PROTECTED]> --- drivers/ieee1394/eth1394.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/ieee1394/eth1394.c b/drivers/ieee1394/eth1394.c index a953135..03e44b3 100644 --- a/drivers/ieee1394/eth1394.c +++ b/drivers/ieee1394/eth1394.c @@ -584,7 +584,10 @@ static void ether1394_add_host (struct hpsb_host *host) } SET_MODULE_OWNER(dev); +#if 0 + /* FIXME - Is this the correct parent device anyway? */ SET_NETDEV_DEV(dev, &host->device); +#endif priv = netdev_priv(dev); - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html