Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=51ec138c6416e9ed2ba0eae3af5f0ea8a90ae44b Commit: 51ec138c6416e9ed2ba0eae3af5f0ea8a90ae44b Parent: 0e81c666dbf95546b3d9ea6ff7d29ea19b988950 Author: Al Viro <[EMAIL PROTECTED]> AuthorDate: Sun Jul 15 20:59:51 2007 +0100 Committer: Linus Torvalds <[EMAIL PROTECTED]> CommitDate: Sun Jul 15 16:40:51 2007 -0700
ieee1394: forgotten dereference... Going through the string and waiting for _pointer_ to become '\0' is not what the authors meant... Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Ben Collins <[EMAIL PROTECTED]> Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]> --- drivers/ieee1394/nodemgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c index c4d3d41..51a1206 100644 --- a/drivers/ieee1394/nodemgr.c +++ b/drivers/ieee1394/nodemgr.c @@ -283,7 +283,7 @@ static ssize_t fw_show_##class##_##td_kv (struct device *dev, struct device_attr memcpy(buf, \ CSR1212_TEXTUAL_DESCRIPTOR_LEAF_DATA(class->td_kv), \ len); \ - while ((buf + len - 1) == '\0') \ + while (buf[len - 1] == '\0') \ len--; \ buf[len++] = '\n'; \ buf[len] = '\0'; \ - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html