Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e923090ddd9fef1d4e06dc6c5295e29baced19f3
Commit:     e923090ddd9fef1d4e06dc6c5295e29baced19f3
Parent:     c7293870a93a99e9ce0f4d98f3a271539c7c6ad6
Author:     Albert Lee <[EMAIL PROTECTED]>
AuthorDate: Mon Aug 20 16:56:29 2007 +0800
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:55:37 2007 -0400

    libata: pata_pdc2027x PLL detection minor cleanup
    
    Minor cleanup to remove the unneeded rmb()s per Jeff's advice. Also removed 
the
    pll_clock < 0 check since pll_clock now guaranteed to be >= 0 after 
Mikael's patch.
    
    Signed-off-by: Albert Lee <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 drivers/ata/pata_pdc2027x.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
index 40b070e..2141a99 100644
--- a/drivers/ata/pata_pdc2027x.c
+++ b/drivers/ata/pata_pdc2027x.c
@@ -561,12 +561,10 @@ static long pdc_read_counter(struct ata_host *host)
 retry:
        bccrl = readl(mmio_base + PDC_BYTE_COUNT) & 0x7fff;
        bccrh = readl(mmio_base + PDC_BYTE_COUNT + 0x100) & 0x7fff;
-       rmb();
 
        /* Read the counter values again for verification */
        bccrlv = readl(mmio_base + PDC_BYTE_COUNT) & 0x7fff;
        bccrhv = readl(mmio_base + PDC_BYTE_COUNT + 0x100) & 0x7fff;
-       rmb();
 
        counter = (bccrh << 15) | bccrl;
 
@@ -741,9 +739,6 @@ static int pdc_hardware_init(struct ata_host *host, 
unsigned int board_idx)
         */
        pll_clock = pdc_detect_pll_input_clock(host);
 
-       if (pll_clock < 0) /* counter overflow? Try again. */
-               pll_clock = pdc_detect_pll_input_clock(host);
-
        dev_printk(KERN_INFO, host->dev, "PLL input clock %ld kHz\n", 
pll_clock/1000);
 
        /* Adjust PLL control register */
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to