Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7a3a16fe7ddf0570e2fcf286d7e244a5e1e16f6a
Commit:     7a3a16fe7ddf0570e2fcf286d7e244a5e1e16f6a
Parent:     5ab063e397d9f6fcadb37a07465efcc87f9e9345
Author:     Tejun Heo <[EMAIL PROTECTED]>
AuthorDate: Wed Feb 13 18:20:19 2008 +0900
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Fri Feb 15 13:51:12 2008 -0500

    pata_legacy: don't call ata_host_detach() after initialization failure
    
    ata_host_detach() detaches an attached port and shouldn't be called on
    a port which hasn't been attached yet.  pata_legacy incorrectly calls
    ata_host_detach() on unattached port after initialization failure
    causing oops.  Fix it.
    
    Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
    Cc: Alan Cox <[EMAIL PROTECTED]>
    Cc: Ingo Molnar <[EMAIL PROTECTED]>
    Cc: Arjan van de Ven <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 drivers/ata/pata_legacy.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index 6c59969..d2177f7 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe 
*probe)
                }
        }
 fail:
-       if (host)
-               ata_host_detach(host);
        platform_device_unregister(pdev);
        return ret;
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to