Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c007c06e3cccf6d80de7f97242da1c3146c431b2
Commit:     c007c06e3cccf6d80de7f97242da1c3146c431b2
Parent:     c483bab099cb89e92b7cad94a52fcdaf37e56657
Author:     Stephen Mollett <[EMAIL PROTECTED]>
AuthorDate: Tue May 8 00:31:31 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue May 8 11:15:14 2007 -0700

    udf: decrement correct link count in udf_rmdir
    
    It appears that a minor thinko occurred in udf_rmdir and the
    (already-cleared) link count on the directory that is being removed was
    being decremented instead of the link count on its parent directory.  This
    gives rise to lots of kernel messages similar to:
    
    UDF-fs warning (device loop1): udf_rmdir: empty directory has nlink != 2 (8)
    
    when removing directory trees.  No other ill effects have been observed but
    I guess it could theoretically result in the link count overflowing on a
    very long-lived, much modified directory.
    
    Signed-off-by: Stephen Mollett <[EMAIL PROTECTED]>
    Cc: Dave Hansen <[EMAIL PROTECTED]>
    Cc: Jan Kara <[EMAIL PROTECTED]>
    Cc: <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 fs/udf/namei.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index fe361cd..b254375 100644
--- a/fs/udf/namei.c
+++ b/fs/udf/namei.c
@@ -878,7 +878,7 @@ static int udf_rmdir(struct inode * dir, struct dentry * 
dentry)
                        inode->i_nlink);
        clear_nlink(inode);
        inode->i_size = 0;
-       inode_dec_link_count(inode);
+       inode_dec_link_count(dir);
        inode->i_ctime = dir->i_ctime = dir->i_mtime = 
current_fs_time(dir->i_sb);
        mark_inode_dirty(dir);
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to