Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=142d0a674d50b53366bd5ea02d7093d04960744e
Commit:     142d0a674d50b53366bd5ea02d7093d04960744e
Parent:     d9f8bcbf67a0ee67c8cb0734f003dfe916bb5248
Author:     Thomas Gleixner <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 14 13:20:48 2007 +0100
Committer:  Thomas Gleixner <[EMAIL PROTECTED](none)>
CommitDate: Sat Nov 17 16:27:00 2007 +0100

    x86: fix bogus memcpy in es7000_check_dsdt()
    
    es7000_check_dst() contains a memcpy from 0, which probably should have been
    a memset. Remove it and check the retunr value from acpi_get_table_header.
    
    Noticed by: Joe Perches <[EMAIL PROTECTED]>
    
    Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
---
 include/asm-x86/mach-es7000/mach_mpparse.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/asm-x86/mach-es7000/mach_mpparse.h 
b/include/asm-x86/mach-es7000/mach_mpparse.h
index 8aa1054..52ee75c 100644
--- a/include/asm-x86/mach-es7000/mach_mpparse.h
+++ b/include/asm-x86/mach-es7000/mach_mpparse.h
@@ -29,9 +29,9 @@ extern int mps_oem_check(struct mp_config_table *mpc, char 
*oem,
 static inline int es7000_check_dsdt(void)
 {
        struct acpi_table_header header;
-       memcpy(&header, 0, sizeof(struct acpi_table_header));
-       acpi_get_table_header(ACPI_SIG_DSDT, 0, &header);
-       if (!strncmp(header.oem_id, "UNISYS", 6))
+
+       if (ACPI_SUCCESS(acpi_get_table_header(ACPI_SIG_DSDT, 0, &header)) &&
+           !strncmp(header.oem_id, "UNISYS", 6))
                return 1;
        return 0;
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to