raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7d57dfbe9cf6f683b1f07cb3aaa887fc8ba7ad77
commit 7d57dfbe9cf6f683b1f07cb3aaa887fc8ba7ad77
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date: Wed Dec 9 14:21:10 2015 +0900
efl - ecore-x randr - fix coverity issue found after previous leak fix
fix coverity issue pointed out in the previous commit fix:
dadc1451e7f53d64b9b848d18c4c2514d791c53e
use after free of ptr (free was in wrong spot)
@fix
---
src/lib/ecore_x/xlib/ecore_x_randr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/ecore_x/xlib/ecore_x_randr.c
b/src/lib/ecore_x/xlib/ecore_x_randr.c
index 551e125..3277045 100644
--- a/src/lib/ecore_x/xlib/ecore_x_randr.c
+++ b/src/lib/ecore_x/xlib/ecore_x_randr.c
@@ -2669,13 +2669,14 @@ ecore_x_randr_output_backlight_level_get(Ecore_X_Window
root EINA_UNUSED, Ecore_
if ((!prop) || (items == 0))
{
- free(prop);
/* check legacy backlight property
*
* FIXME: NB: Not sure what randr version we need for the legacy
* backlight property so skip version check */
if ((backlight = XInternAtom(_ecore_x_disp, "BACKLIGHT", True)))
{
+ free(prop);
+ prop = NULL;
XRRGetOutputProperty(_ecore_x_disp, output, backlight, 0, 4,
False, False, None, &type, &format,
&items, &bytes, &prop);
--
