q66 pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=c420cbe9f02d134d691402a115c00674b5ba37ae

commit c420cbe9f02d134d691402a115c00674b5ba37ae
Author: Daniel Kolesa <d.kol...@osg.samsung.com>
Date:   Fri Mar 11 13:04:33 2016 +0000

    eolian: refactor database_typedecl_to_str to remove dead code
    
    After the type system transition there was some unnecessary dead code.
    Fixes CID 1352512.
---
 src/lib/eolian/database_type.c | 30 +++++++++++-------------------
 1 file changed, 11 insertions(+), 19 deletions(-)

diff --git a/src/lib/eolian/database_type.c b/src/lib/eolian/database_type.c
index ec3b9a8..749281b 100644
--- a/src/lib/eolian/database_type.c
+++ b/src/lib/eolian/database_type.c
@@ -217,27 +217,19 @@ _atype_to_str(const Eolian_Typedecl *tp, Eina_Strbuf *buf)
 void
 database_typedecl_to_str(const Eolian_Typedecl *tp, Eina_Strbuf *buf, const 
char *name)
 {
-   if (tp->type == EOLIAN_TYPEDECL_ALIAS)
+   switch (tp->type)
      {
+      case EOLIAN_TYPEDECL_ALIAS:
         _atype_to_str(tp, buf);
-        return;
-     }
-   else if (tp->type == EOLIAN_TYPEDECL_STRUCT
-         || tp->type == EOLIAN_TYPEDECL_STRUCT_OPAQUE)
-     {
-        _stype_to_str(tp, buf, name);
-        return;
-     }
-   else if (tp->type == EOLIAN_TYPEDECL_ENUM)
-     {
+        break;
+      case EOLIAN_TYPEDECL_ENUM:
         _etype_to_str(tp, buf, name);
-        return;
-     }
-   else
-     return;
-   if (name)
-     {
-        eina_strbuf_append_char(buf, ' ');
-        eina_strbuf_append(buf, name);
+        break;
+      case EOLIAN_TYPEDECL_STRUCT:
+      case EOLIAN_TYPEDECL_STRUCT_OPAQUE:
+        _stype_to_str(tp, buf, name);
+        break;
+      default:
+        break;
      }
 }

-- 


Reply via email to