stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=342db1ee38eca08fdc0d7cadd7ee3692d538afeb
commit 342db1ee38eca08fdc0d7cadd7ee3692d538afeb
Author: Srivardhan Hebbar <sri.heb...@samsung.com>
Date: Mon Sep 7 13:30:48 2015 +0200
ecore_example: Fixing NULL deference.
Summary:
pd was dereferenced and then checked for NULL. If it was NULL, the program
would crash much before. So fixed that.
Signed-off-by: Srivardhan Hebbar <sri.heb...@samsung.com>
Reviewers: cedric, stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3031
---
src/examples/ecore/ecore_buffer_provider_example.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/examples/ecore/ecore_buffer_provider_example.c
b/src/examples/ecore/ecore_buffer_provider_example.c
index 112854b..5d1d5b0 100644
--- a/src/examples/ecore/ecore_buffer_provider_example.c
+++ b/src/examples/ecore/ecore_buffer_provider_example.c
@@ -246,7 +246,7 @@ main(void)
pd = (Provider_Data *)calloc(sizeof(Provider_Data), 1);
- if (!(pd->provider = ecore_buffer_provider_new(name)))
+ if (!pd || !(pd->provider = ecore_buffer_provider_new(name)))
{
LOG("Failed to create provider");
goto shutdown;
@@ -267,7 +267,7 @@ shutdown:
ecore_buffer_free(b);
}
if (pd->provider) ecore_buffer_provider_free(pd->provider);
- if (pd) free(pd);
+ free(pd);
shutdown_all();
return 0;
--
