devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=eb11b7f26e568d07799221418bf2c1d4fce8d1d5
commit eb11b7f26e568d07799221418bf2c1d4fce8d1d5
Author: Chris Michael <cpmich...@osg.samsung.com>
Date: Fri Feb 12 08:25:20 2016 -0500
ecore-x: Add EINA_SAFETY checks for missing display
xlib immediately crashes upon being passed a null DISPLAY object,
so every function in ecore-x should likely have safety checks such
as these.
@fix
Signed-off-by: Chris Michael <cpmich...@osg.samsung.com>
---
src/lib/ecore_x/xlib/ecore_x_cursor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/ecore_x/xlib/ecore_x_cursor.c
b/src/lib/ecore_x/xlib/ecore_x_cursor.c
index aacc831..46ac42e 100644
--- a/src/lib/ecore_x/xlib/ecore_x_cursor.c
+++ b/src/lib/ecore_x/xlib/ecore_x_cursor.c
@@ -20,6 +20,7 @@ ecore_x_cursor_new(Ecore_X_Window win,
int hot_x,
int hot_y)
{
+ EINA_SAFETY_ON_NULL_RETURN_VAL(_ecore_x_disp, 0);
#ifdef ECORE_XCURSOR
LOGFN(__FILE__, __LINE__, __FUNCTION__);
@@ -233,6 +234,7 @@ ecore_x_cursor_shape_get(int shape)
{
Ecore_X_Cursor cur;
LOGFN(__FILE__, __LINE__, __FUNCTION__);
+ EINA_SAFETY_ON_NULL_RETURN_VAL(_ecore_x_disp, 0);
/* Shapes are defined in Ecore_X_Cursor.h */
cur = XCreateFontCursor(_ecore_x_disp, shape);
if (_ecore_xlib_sync) ecore_x_sync();
--
