raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=c6011926bad960136af132a97b54cb38199638fe
commit c6011926bad960136af132a97b54cb38199638fe
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date: Wed Jun 24 18:35:46 2015 +0900
eo - silence ERR logs on constructor fail - this is valid behavior
@fix
XXX: Given EFL usage of objects, construction is a perfectly valid thing
to do. we shouldn't complain about it as handling a NULL obj creation is
the job of the caller. a perfect example here is ecore_con and ecore_ipc
where you create a con or ipc obj then set up type/destination/port and
the finalize of the constructor does the actual connect and thus this
fails or succeeds based on if service is there.
until there is a better solution - don't complain here.
---
src/lib/eo/eo.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 9609138..b5e24a9 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -974,8 +974,17 @@ _eo_add_internal_end(Eo *eo_id)
if (!eo_id)
{
- ERR("Object of class '%s' - Finalizing the object failed.",
- klass->desc->name);
+// XXX: Given EFL usage of objects, construction is a perfectly valid thing
+// to do. we shouldn't complain about it as handling a NULL obj creation is
+// the job of the caller. a perfect example here is ecore_con and ecore_ipc
+// where you create a con or ipc obj then set up type/destination/port and
+// the finalize of the constructor does the actual connect and thus this
+// fails or succeeds based on if service is there.
+//
+// until there is a better solution - don't complain here.
+//
+// ERR("Object of class '%s' - Finalizing the object failed.",
+// klass->desc->name);
goto cleanup;
}
}
--
