devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=2a7640cb4e21800315942b7d1b66e673eebe2e10
commit 2a7640cb4e21800315942b7d1b66e673eebe2e10
Author: Chris Michael <cp.mich...@samsung.com>
Date: Sun Apr 12 21:04:10 2015 -0400
evas-gl-x11: Fix dereference before null check
Summary: This fixes Coverity CID1293519 where einfo was being used
Before it was being null checked (which Could have caused a crash if
in fact einfo Was NULL).
@fix
Signed-off-by: Chris Michael <cp.mich...@samsung.com>
---
src/modules/evas/engines/gl_x11/evas_x_main.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/modules/evas/engines/gl_x11/evas_x_main.c
b/src/modules/evas/engines/gl_x11/evas_x_main.c
index 816d222..71f54e0 100644
--- a/src/modules/evas/engines/gl_x11/evas_x_main.c
+++ b/src/modules/evas/engines/gl_x11/evas_x_main.c
@@ -792,16 +792,21 @@ void *
eng_best_visual_get(Evas_Engine_Info_GL_X11 *einfo)
{
Evas_GL_X11_Visual *evis;
- int alpha = einfo->info.destination_alpha;
- int depth_bits = einfo->depth_bits;
- int stencil_bits = einfo->stencil_bits;
- int msaa_samples = einfo->msaa_bits;
+ int alpha;
+ int depth_bits;
+ int stencil_bits;
+ int msaa_samples;
int config_attrs[40], i, num, idx;
Eina_Bool found;
if (!einfo) return NULL;
if (!einfo->info.display) return NULL;
+ alpha = einfo->info.destination_alpha;
+ depth_bits = einfo->depth_bits;
+ stencil_bits = einfo->stencil_bits;
+ msaa_samples = einfo->msaa_bits;
+
idx = _visuals_hash_index_get_from_info(einfo);
evis = eina_hash_find(_evas_gl_visuals, &idx);
if (evis)
--
