tasn pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=178e7e6ac9419742d1bbe583fd252fc6536e5649
commit 178e7e6ac9419742d1bbe583fd252fc6536e5649
Author: Tom Hacohen <t...@stosb.com>
Date: Sun Oct 4 15:09:40 2015 +0100
Genlist: only get item data if needed.
Moved the data fetching to be after the tests. This doesn't really
matter and is mostly there to silence coverity. Coverity was complaining
about "it" being dereferenced before the null check (implicit in
EO_OBJ), so reordering it will fix it.
CID 1040000
---
src/lib/elm_genlist.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index cb71fb9..a5a34ff 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -3941,11 +3941,12 @@ _swipe_do(Elm_Gen_Item *it)
{
int i, sum = 0;
Eina_Bool tmp;
- ELM_GENLIST_DATA_GET_FROM_ITEM(it, sd);
if (_is_no_select(it) ||
eo_do_ret(EO_OBJ(it), tmp, elm_wdg_item_disabled_get())) return;
+ ELM_GENLIST_DATA_GET_FROM_ITEM(it, sd);
+
sd->swipe = EINA_FALSE;
for (i = 0; i < sd->movements; i++)
{
--
