stefan pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=35be09eb3dbe9007680dbf13044c3eda192dfa9e
commit 35be09eb3dbe9007680dbf13044c3eda192dfa9e Author: Stefan Schmidt <ste...@osg.samsung.com> Date: Fri Jul 24 18:35:22 2015 +0200 elf_fileselector: Avoid memory leak in error path If filter_add fails here we would go out of scope and leak custom_filter. Free it instead. CID 1308261 --- src/lib/elc_fileselector.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c index d541c5f..8dc2e03 100644 --- a/src/lib/elc_fileselector.c +++ b/src/lib/elc_fileselector.c @@ -2184,7 +2184,11 @@ _elm_fileselector_elm_interface_fileselector_custom_filter_append(Eo *obj, Elm_F if (!custom_filter) return EINA_FALSE; ff = _filter_add(sd, filter_name ? filter_name : "custom"); - if (!ff) return EINA_FALSE; + if (!ff) + { + free(custom_filter); + return EINA_FALSE; + } ff->filter_type = ELM_FILESELECTOR_CUSTOM_FILTER; ff->filter.custom = custom_filter; --