discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=9d3f4564b3b808adf4f94dabb39e9138112af2a9

commit 9d3f4564b3b808adf4f94dabb39e9138112af2a9
Author: Mike Blumenkrantz <zm...@osg.samsung.com>
Date:   Thu Feb 25 14:00:01 2016 -0500

    make bgpreview create vdesk config dialog on mouse up instead of mouse down
    
    if the option to always raise a window on click is enabled, clicking an 
internal
    window in a way which creates another window will cause a race condition 
where
    the clicked window is raised over the newly created window
    
    there is no obvious policy-wide solution to this issue, but making this 
change
    at least resolves the issue in question
    
    fix T3210
---
 src/bin/e_widget_bgpreview.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/bin/e_widget_bgpreview.c b/src/bin/e_widget_bgpreview.c
index 65438b7..ee6fc7e 100644
--- a/src/bin/e_widget_bgpreview.c
+++ b/src/bin/e_widget_bgpreview.c
@@ -147,10 +147,10 @@ e_widget_bgpreview_desk_configurable_set(Evas_Object 
*obj, Eina_Bool enable)
    enable = !!enable;
    if (dd->configurable == enable) return;
    if (enable)
-     evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_DOWN,
+     evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_UP,
                                     _e_wid_desk_cb_config, dd);
    else
-     evas_object_event_callback_del_full(dd->icon, EVAS_CALLBACK_MOUSE_DOWN,
+     evas_object_event_callback_del_full(dd->icon, EVAS_CALLBACK_MOUSE_UP,
                                          _e_wid_desk_cb_config, dd);
    dd->configurable = enable;
 }
@@ -294,7 +294,7 @@ _e_wid_reconfigure(E_Widget_Data *wd)
 
              edje_object_part_swallow(dd->icon, "e.swallow.content", dd->cont);
              dd->configurable = EINA_TRUE;
-             evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_DOWN,
+             evas_object_event_callback_add(dd->icon, EVAS_CALLBACK_MOUSE_UP,
                                             _e_wid_desk_cb_config, dd);
              evas_object_show(dd->icon);
              evas_object_data_set(dd->icon, "desk_data", dd);

-- 


Reply via email to