rimmed pushed a commit to branch master.

http://git.enlightenment.org/tools/eflete.git/commit/?id=f8eb77243aa763ec3de2b3cb10e35b721cc3000c

commit f8eb77243aa763ec3de2b3cb10e35b721cc3000c
Author: Andrii Kroitor <an.kroi...@samsung.com>
Date:   Fri Feb 5 15:12:43 2016 +0200

    group_navigator: fix bug with double clicking on state
    
    Genlist can call double click/activated callback without calling selected 
callback.
    This happens if you click on one item and then fast on another one.
    Looks like this should be fixed in elementary
---
 src/bin/ui/group_navigator.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/bin/ui/group_navigator.c b/src/bin/ui/group_navigator.c
index 403d6d0..de3269c 100644
--- a/src/bin/ui/group_navigator.c
+++ b/src/bin/ui/group_navigator.c
@@ -315,6 +315,12 @@ group_navigator_part_state_select(Evas_Object *obj, State 
*state)
    assert(pl != NULL);
    assert(state != NULL);
 
+   part = elm_object_item_data_get(pl->selected_part_item);
+
+   TODO("replace this with assert after genlist double-click bug will be 
fixed");
+   if (state->part != part)
+     group_navigator_part_select(pl->layout, state->part);
+
    if (elm_genlist_item_expanded_get(pl->selected_part_item))
      {
         /* unselecting previous selected state */
@@ -333,10 +339,9 @@ group_navigator_part_state_select(Evas_Object *obj, State 
*state)
         elm_genlist_item_item_class_update(selected, pl->itc_state_selected);
      }
 
-   part = elm_object_item_data_get(pl->selected_part_item);
-   part->current_state = state;
+   state->part->current_state = state;
 
-   evas_object_smart_callback_call(ap.win, SIGNAL_PART_STATE_SELECTED, (void 
*)part);
+   evas_object_smart_callback_call(ap.win, SIGNAL_PART_STATE_SELECTED, (void 
*)state->part);
 }
 
 static void

-- 


Reply via email to